-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor code #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Juliette-Gerbaux
wants to merge
28
commits into
multi_stock
Choose a base branch
from
Refactor-code
base: multi_stock
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AreaIndex in multi_stock_management * stock_discretization * simple_bellman_value_calculation * reservoir_management * optimization * multi_stock_bellman_value_calculation * functions_iterative --------- Co-authored-by: Juliette-Gerbaux <[email protected]>
* Param in conftest * Stock management in conftest * Test on calling SDDP with precalculated reward * Add test on bellman values * Final level * Fix test * Improve bellman values definition * Compute bounds * Ubuntu version in ci * Update numpy version * More levels for exact two stocks --------- Co-authored-by: Juliette-Gerbaux <[email protected]>
* Test on solve weekly problem with approximation * Noise penalty in calculate vu * Fix test * Remove reward interpolation * Fix test --------- Co-authored-by: Juliette-Gerbaux <[email protected]>
* Change input format on LinearCostEstimator * generate controls output * LinearCostEstimator everywhere * n-cycle inside get_bellman_values_from_costs * Fix test
* define levels outside bellman values computation * Simplify initialize future costs * Change output of compute_bellman_values_from_costs * Weekly bellman problem defined per week * Uniformise __init__ of problems * Indexes on rule curves (in Antares, there are defined for the beginning of the day) * Fix tests * Fix penalty cost in WeeklyBellmanProblem * WeeklyBellmanProblem in solve_with_approximate_reward * Uniformize calculate_VU and overflow * Unique function for bellman values and optimal trajectory from approximate costs * Unique function get_reward * Unique function precalculated --------- Co-authored-by: Juliette-Gerbaux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.