Skip to content

Conversation

@UnicornMaster-dev
Copy link

@UnicornMaster-dev UnicornMaster-dev commented May 6, 2025

Description

I have updated the code to simply function without loss of other functions for 1.21.5 aka provide support for new the newest version. I have commented out Skeleton ESP because I could not understand the rendering system in the latest version.

Related Issue

[Suggestion] support for the 1.21.5 #427

Motivation and Context

This change is useful as meteor has updated to 1.21.5 and many users always use the latest version of meteor.
This is a fix for the issue [Suggestion] support for the 1.21.5 #427

How Has This Been Tested?

I have tested every module/config/hud change in game, and it all works just as before. I ran the tests inside minecraft, and launched the game through Intellij's minecraft development plugin. I tested the features on a server I ran myself.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • Have you successfully ran tests with your changes locally?

@Nippaku-Zanmu
Copy link

I'm having a bug with this version

Description of the bug:
This mod causes the GUI of the Meteor client to not open properly

How to reproduce the bug:

  1. Install and enable this plugin normally and open the GUI of the Meteor client inside the single-player world
  2. The GUI is turned on normally
  3. Modify the setting of the module that involves the addition of setting to the mod and save it to exit the game
  4. Open the mc client again and launch the Meteor GUI interface At this point, the Meteor GUI cannot be opened normally
javaw_HFJU8jej8A

This bug may be caused by calling the factories.put() function in the RejectsSettings class

In addition, I have had this kind of problem with the private plugin I wrote
I've tried changing the loading method of the custom Setting to call the SettingsWidgetFactory.registerCustomFactory() function inside the Meteor client, but it also causes this issue

I can't solve this problem because there is no error message about it in the console at all
It's just stuck in a blank interface, and you can't just do it

@UnicornMaster-dev
Copy link
Author

I'm not entirely sure about what you mean with step 3. Modify what setting on what module?

@Nippaku-Zanmu
Copy link

I think I should have fixed this problem, I just updated my graphics driver, and it didn't appear after that (I didn't try it much, I don't rule out chances)

I'm not entirely sure about what you mean with step 3. Modify what setting on what module?

@dslord
Copy link

dslord commented May 12, 2025

Hello,
Where can I download this updated version of meteor rejects which is updated here. Also I have tried the latest build on 1.21.5, It seemed to only work when it is freshly installed and the meteor files are made, afterwards when I reboot minecraft it does not work and it gives the error "Fonts.refresh". If you delete the meteor client folder and start the game again it works.

@dslord
Copy link

dslord commented May 14, 2025

is this addon abandoned?

@UnicornMaster-dev
Copy link
Author

@devansh424 No this version is a pull request I've made, though they have not responded. Currently this is not offically available for download. But if you go into checks then artifacts and download the zip in there the file. Inside of the zip is the .jar file that is the is the updated version.

@dslord
Copy link

dslord commented May 15, 2025

Ok thank you.

EDIT: I tried your updated mod with meteor client 1.21.5#17, It does not work with my mods collection, The game neither crashes with an error nor starts properly.

@UnicornMaster-dev
Copy link
Author

UnicornMaster-dev commented May 17, 2025

@devansh424 Go to your crash logs and see if there is anything new and give me a list of the mods you use. If it still has nothing then I'm not sure I can help as In my testing it worked fine and it has been working for others aswell.

@dslord
Copy link

dslord commented May 17, 2025

@devansh424 Go to your crash logs and see if there is anything new and give me a list of the mods you use. If it still has nothing then I'm not sure I can help as In my testing it worked fine and it has been working for others aswell.

As I said there was no crash log generated my game was just in type of hang mode so it neither started nor crashed with an error, I had to stop it from the Task Manager manually.

Here is the list of mods I use (I have tried your updated version with all these mods on latest 1.21.5)
Screenshot 2025-05-17 154509

@UnicornMaster-dev
Copy link
Author

UnicornMaster-dev commented May 17, 2025

@devansh424

Here is the list of mods I use (I have tried your updated version with all these mods on latest 1.21.5)

By this line I assume you have the 1.21.5 version of all the mods listed. I've tested this in game with the same mods, I had no issue with these mods
Screenshot 2025-05-17 080634
My only idea is this being an issue with tloader skin capes because I do not download things based on tloader.

@dslord
Copy link

dslord commented May 17, 2025

Ok. I suppose it's because of TLauncher, I will try this again with a different launcher. I will notify you

@Wyldx717
Copy link

Wyldx717 commented May 17, 2025

Hey! Ive tried it out and it does work, however when i run .seed the latest version i can use is 1.21.3 which shows incorrect Ores (on DonutSMP) since the server runs on 1.21.5. Any ideas on a workaround?

Edit: I did something wrong, works perfectly now!

@dslord
Copy link

dslord commented May 18, 2025

@UnicornMaster-dev I tried all the mods with the addon again and my game launched without any errors but when I tried opening the GUI through mod menu and my game just froze and it was not responding, I tested this with meteor#18 1.21.5

@UnicornMaster-dev
Copy link
Author

I see no reason to open it through mod menu, but regardless in my testing it has no problems.

2025-05-18.10-50-29.mp4

@dslord
Copy link

dslord commented May 19, 2025

@UnicornMaster-dev
I don't know why the hell it's not working for me, also try opening it in from the home screen of minecraft, not while playing, It is helpful if you are not in a game and if you just want to edit the gui so you can do it from the home screen. Also do you have real minecraft or the cracked one. Please try with a cracked account too (just curious if its cause of cracked account)

EDIT: I tried the mod again and its not working while playing the game too, I opened the GUI and it just froze the game after minimizing and reopening minecraft it just flashes the minecraft loading screen continuously. Is it because of hardware problems? I am using integrated GPU

@N1CK1111
Copy link

Works great from the build artifact. This PR gotta get merged.

@skeoc skeoc mentioned this pull request May 19, 2025
@UnicornMaster-dev
Copy link
Author

@devansh424 I am using a cracked account for testing. Try backing up then deleting your config folder and meteor client folder in .minecraft or whatever folder contains your mods folder as that could be causing the issue. Another thing is check if your drivers are outdated.

@Mcedro123
Copy link

How can i download this 1.21.5 rejects?

Copy link

@Mcedro123 Mcedro123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@dslord
Copy link

dslord commented May 21, 2025

@UnicornMaster-dev
I tried your solution but it's still not working, It is the same issue as before. Is your fabric loader is on latest version? (0.16.14) and I also noticed in the video that you sent, you are using Meteor Client version 1.21.5#16 instead of the latest version Meteor Client version 1.21.5#24... Please try it with latest version.

@UnicornMaster-dev
Copy link
Author

UnicornMaster-dev commented May 21, 2025

I tried it with meteor 1.21.5#24 no problems and I've also tried loader version 0.16.14 with no problems. Without any kind of crash report or log, debugging the problem is very annoying. I found some mods that do stuff for crash logs, I know you've said you don't get a crash log if you check your crash logs in the files then you can find debug.log and latest.log which sometimes just log things not always crashes.
https://modrinth.com/mod/stackdeobf
https://modrinth.com/mod/crash-assistant
https://modrinth.com/mod/notenoughcrashes
https://modrinth.com/mod/improvedcrashreports

@Alex69420Real
Copy link

Alex69420Real commented May 22, 2025

could you maybe add the oresim version 1.21.4 and 1.21.5 cause if you do .seed it doesnt pop up for me
thank you tho

@UnicornMaster-dev
Copy link
Author

@Alex69420Real When I do .seed in my testing world it works fine and oresim is working do you receive any errors or are you using any other mods?

@Alex69420Real
Copy link

@UnicornMaster-dev my bad i was using it on donut smp and sometimes for me it just bugs out and shows wrong pos for ores (i realised you have to use 1.21)

@dslord
Copy link

dslord commented May 26, 2025

@UnicornMaster-dev
I may have found the error, There is an error logged in the latest.log file and it is related to baritone. I will paste the error here.

[11:39:51] [main/WARN]: Error loading class: baritone/command/defaults/ComeCommand (java.lang.ClassNotFoundException: baritone/command/defaults/ComeCommand)
[11:39:51] [main/WARN]: @mixin target baritone.command.defaults.ComeCommand was not found meteor-client-baritone.mixins.json:ComeCommandMixin from mod meteor-client
[11:39:51] [main/WARN]: Error loading class: baritone/process/MineProcess (java.lang.ClassNotFoundException: baritone/process/MineProcess)
[11:39:51] [main/WARN]: @mixin target baritone.process.MineProcess was not found meteor-rejects.mixins.json:baritone.MineProcessMixin from mod meteor-rejects

Also I read @Nippaku-Zanmu issue and I think I am having exact same problem with me, but just the problem is that even my graphics driver is upto date but it is still not working.
I tried the updated mod without any other mod (just the 2 files of meteor client and meteor addon) It just does not work, It also restarts my whole explorer without any reason when I click on minecraft multiple times

@fortune428
Copy link

When I join a 3-rd party server(version is 1.21.1),,I try to use the .locate command,but the game crashes.
I review the crash log,finally find a NullPointerException caused by LocateCommand function.
which doesnt ruturn a proper value
crash-2025-05-27_18.18.58-client.txt

@dslord
Copy link

dslord commented May 27, 2025

Make sure you have the latest version of baritone from The meteor website. Have you had any issues with meteor rejects on 1.21.4? Though I can't imagine why the addon would be causing explorer to restart.

Is baritone a dependency? I don't use it but this error is logged everytime I boot minecraft... I don't have any issues with meteor rejects on 1.21.4. I almost tried everything I don't know what to do now.

@Encryption-c08
Copy link

Make sure you have the latest version of baritone from The meteor website. Have you had any issues with meteor rejects on 1.21.4? Though I can't imagine why the addon would be causing explorer to restart.

Is baritone a dependency? I don't use it but this error is logged everytime I boot minecraft... I don't have any issues with meteor rejects on 1.21.4. I almost tried everything I don't know what to do now.

No baritone is not a dependency

@UnicornMaster-dev
Copy link
Author

@fortune428 I'm afraid this is the incorrect place to talk about this, as this is my version of the plugin for 1.21.5 not 1.21.1.

@fortune428
Copy link

@fortune428 I'm afraid this is the incorrect place to talk about this, as this is my version of the plugin for 1.21.5 not 1.21.1.

you can join 1.21.1 server with viafabricplus,I mean

@UnicornMaster-dev
Copy link
Author

@fortune428 I have tried my fork on 1.21.5 and joined a 1.21.1 server I used viafabricplus to join, I have run the command and still am running into no problems.

Copy link
Contributor

@SIMULATAN SIMULATAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst trying to update my own Notifications addon, I have encountered a problem that I've now confirmed to also be present in this PR.
Using rounded corners results in a crash with this error message:

java.lang.IndexOutOfBoundsException: Vertices written to MeshBuilder without calling 'ensureCapacity()' first!
	at knot//meteordevelopment.meteorclient.renderer.MeshBuilder.debugVertexBufferCapacity(MeshBuilder.java:243)
	at knot//meteordevelopment.meteorclient.renderer.MeshBuilder.vec2(MeshBuilder.java:92)
	at knot//anticope.rejects.utils.gui.RoundedRenderer2D.vecOnCircle(RoundedRenderer2D.java:125)

So far, I haven't found a fix yet as I don't have any Minecraft graphics experience

EDIT: nvm, mb.triangles.ensureTriCapacity() before the vec2 calls seems to do the trick

@UnicornMaster-dev
Copy link
Author

@SIMULATAN Im afraid I don't understand what you mean I have found no crashes on meteor rounded.

@fortune428
Copy link

when you use the .locate command,if you don not have the seed,the game will crash.(you do not have any permission)
the reason is that Seeds.getSeed() returns null,and does not process it.
crash-2025-06-02_10.18.50-client.txt
you can see the crash report.

@fortune428
Copy link

I have tested it on my local server.make sure you are not op.
@UnicornMaster-dev

@UnicornMaster-dev
Copy link
Author

In my testing I was on a 1.21.5 server I did not have op on. When I did checked the seed list it had none, I flew around until I found all the needed structures when seedcrackerx had finished cracking the seed it added it to the list and the .locate command worked fine. This was my experience I have still pushed a change that checks things with getseed.

@relyks12
Copy link

how do i get 1.21.5 rejects? wheres the download

@UnicornMaster-dev
Copy link
Author

@relyks12 If you go into checks then artifacts and download the zip in there the file. Inside of the zip is the .jar file that is the is the updated version.

@matthias7890
Copy link

time for 1.21.6... 😭

@UnicornMaster-dev
Copy link
Author

@matthias7890 They changed the rendering engine again 😭😭I didnt even understand it the first time!

@matthias7890
Copy link

@UnicornMaster-dev Ahhhh 😭

@UnicornMaster-dev
Copy link
Author

@matthias7890 Apart from 1 major crashing problem it has been updated #449

@WisdomGhoul
Copy link

Hello,
It breaks alt management.

@UnicornMaster-dev
Copy link
Author

@WisdomGhoul It appears to be working fine for me can you explain in additional detail what your problem is? Or provide screenshots of the issue.

@WisdomGhoul
Copy link

@WisdomGhoul It appears to be working fine for me can you explain in additional detail what your problem is? Or provide screenshots of the issue.

While loading the mod (and only this mod and Meteor 1.21.5 47, the "Accounts" button on the servers list shows me the connected account, but while i press the "Login" button, nothing happens. When I load the game without the mod, everything works fine.

@UnicornMaster-dev
Copy link
Author

Is this for any specific login method as for me logging into cracked accounts works fine though I don't have any of the alt services I could use to test it. Additionally I have made no modifications to it so it may need an overhaul for a system I don't understand and can't test.

@Clon27
Copy link

Clon27 commented Jul 14, 2025

Yo how can i download it wanted to use rejects for 1.21.5 but i cant download this (im new to Github

@UnicornMaster-dev
Copy link
Author

@Clon27 If you go into checks then artifacts and download the zip in there the file. Inside of the zip is the .jar file that is the is the updated version.

@Clon27
Copy link

Clon27 commented Jul 14, 2025

ok thanks

@ghost
Copy link

ghost commented Dec 1, 2025

the artifact says its expired, any chance this is still around?

@pizzav-xyz
Copy link

Just build it yourself

1 similar comment
@pizzav-xyz
Copy link

Just build it yourself

@shivpatil1204
Copy link

The artifact has expired, any chance you still have the file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.