[WIP] 1.17 fabric 3rd person render #398
Conversation
tyra314
left a comment
tyra314
left a comment
There was a problem hiding this comment.
Thanks for the reminder. But I assume it's not ready yet.
| matrices.translate(0, 0, 0.01); | ||
| Textures.BOOK.drawWithLight(buffer, matrices, 0, 0, (int) (GuiAtlas.WIDTH * 1.5), (int) (GuiAtlas.HEIGHT * 1.5), light); | ||
| // Book backside | ||
| Textures.BOOK.drawWithLightFlipped(buffer, matrices, 0, 0, (int) (GuiAtlas.WIDTH * 1.5), (int) (GuiAtlas.HEIGHT * 1.5), light); |
There was a problem hiding this comment.
I guess without NEA this should not be drawn, as nobody would see it anyways
There was a problem hiding this comment.
Yea in the current state this is missing these checks since I don't know the way you guys are planning to implement it. When there is no way to see the backside(so no NEA), this can be skipped of cause.
| } | ||
| if (arm != entity.getMainArm() && entity.getOffHandStack().getItem().equals(RegistrarAntiqueAtlas.ATLAS)) { // Only offhand | ||
| matrices.push(); | ||
| ((ModelWithArms) getContextModel()).setArmAngle(arm, matrices); |
There was a problem hiding this comment.
I have the very strong feeling, this code redundancy could be refactored away.
There was a problem hiding this comment.
That's true, its a bit of a copy and paste job that was different, but now could be refactored since these differences are not there any more.
2 participants
Before this gets fully forgotten, this branch adds 3rd person rendering that works in combination with Not Enough Animations. Currently there are two options: disable this feature when NEA is not pressent, or copy over the arm translation mixins to make it work without NEA. Also the Atlas is currently missing its back texture.