Hover Map, context menu and accessibility settings#830
Hover Map, context menu and accessibility settings#830UAC-MaxxLite wants to merge 23 commits intounstablefrom
Conversation
unfinished testing
|
Add images pls |
Added images to the pr |
UnseenKill
left a comment
There was a problem hiding this comment.
I like it. Going to take it for a test ride right now.
|
Resolved merge conflicts, double check for errors/functionality with an ingame test @UAC-MaxxLite |
| private _milAdminPositions = getArray (_mapInfo/"milAdministrations"); | ||
| private _milAdminMarkersToUpdate = []; | ||
|
|
||
| { |
There was a problem hiding this comment.
Just FYI: this is a prime example of why code convention three exists.
Also, question: this code will now hide markers of miladmins whose building is destroyed; this might not necessarily mean that the miladmin is cleared, though. The officer might still be alive...
There was a problem hiding this comment.
mil admins are weird, at least for me.
right now mil admins dont get hidden at all, but the functionality is different, an alive mil admin wont have the hover option but a dead one will, and i cant get the hover to work on both....
Co-authored-by: UnseenKill <post@oliver-schieche.de> Signed-off-by: MaxxLite <162753200+UAC-MaxxLite@users.noreply.github.com>
Co-authored-by: UnseenKill <post@oliver-schieche.de> Signed-off-by: MaxxLite <162753200+UAC-MaxxLite@users.noreply.github.com>
Signed-off-by: UnseenKill <post@oliver-schieche.de>
Co-authored-by: UnseenKill <post@oliver-schieche.de> Signed-off-by: MaxxLite <162753200+UAC-MaxxLite@users.noreply.github.com>




What type of PR is this?
Sub-categories:
What have you changed, and why?
Information:
Changed functionality and look of the map, added accessibility settings to addon settings.
Removed:
Added:
The following zones now have added names to the start of them:
New context menu to every marker that enables when marker is pressed, with the following information:
How can your changes be tested, or reproduced?
open the map and go wild
use the hideenemymarkers param to check for issues (I gave up an military administrations)
play around with the location browser to check for edge cases
Does this PR include changes not authored by you?
Further info:
Please verify the following (If possible).
*- Mandatory**Is further work needed?
Please specify which Issue this PR Resolves (If Applicable).
This PR closes #XYZ.
Notes:
I might have missed something or have left over code as the files are big and work on them took a long time
If any marker is not to your liking or you found an issue with it please tell me so i could review the issue and change if needed