Skip to content

Hover Map, context menu and accessibility settings#830

Open
UAC-MaxxLite wants to merge 23 commits intounstablefrom
map-marker-enhancement
Open

Hover Map, context menu and accessibility settings#830
UAC-MaxxLite wants to merge 23 commits intounstablefrom
map-marker-enhancement

Conversation

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator

@UAC-MaxxLite UAC-MaxxLite commented Mar 8, 2026

What type of PR is this?

  • Bug
  • Change
  • Feature
  • Miscellaneous
Sub-categories:
  • Template
  • Map
  • Config
  • Function
  • Localization

What have you changed, and why?

Information:

Changed functionality and look of the map, added accessibility settings to addon settings.

Removed:

  • Nearly all map markers
  • Most of the markers no longer have text other then important POI's (Can be disabled in addon settings)

Added:

  • Markers now able to be hovered
    • When hovered will show the following (Marker Name along with and icon, flag/icon)
image_2026-03-08_143536675
  • Accessibility:
    • Added color blindness setting for easier marker readability
image_2026-03-08_143315859
  • The following zones now have added names to the start of them:

    • Military Administrations (Added the closest city to the name)
    • Factories (Added the closest city to the name)
    • Resources (Added the closest city to the name)
    • Outposts (Added a prefix from a set list)
    • Seaports (Added a prefix from a set list)
    • Military Bases (Added a prefix from a set list)
    • Airbases (Added a prefix from a set list)
  • New context menu to every marker that enables when marker is pressed, with the following information:

    • Fast travel button
    • Garrison button
    • Close button (can be closed by simply clicking off the menu)
    • Information about the zone
    • Garrison panel if more then 1 soldier is garrisoned
image_2026-03-08_143613923
  • New marker browser (Allows to brows for marker names using filters and a search bar)
image_2026-03-08_143650031
  • New markers for the following zones:
    • Cities
    • Hq
    • Black Market Trader
    • Rally point
    • Observation Post
    • Roadblock
    • AA Emplacement
    • AT Emplacement
    • HMG Emplacement
    • Mil Admins
    • Outposts
    • Resources
    • Factories
    • Military Bases
    • Sea Ports
    • Flag for arms dealer
image_2026-03-08_143206286

How can your changes be tested, or reproduced?

open the map and go wild
use the hideenemymarkers param to check for issues (I gave up an military administrations)
play around with the location browser to check for edge cases

Does this PR include changes not authored by you?

  • No
  • Yes (See below)
Further info:
  • I confirm that I, and by extension this repository, can legally use these third-party changes. (Provide links or author attribution.)

...

Please verify the following (If possible).

* - Mandatory

  • These changes are my own, or I have written permission to use them. *
  • These changes are ready for review, or will be marked as a draft. *
  • I have loaded the mission in LAN host.
  • I have loaded the mission on a dedicated server.

Is further work needed?

  • Needs further testing.
  • Needs further changes.
  • Needs to be converted to a draft.

Please specify which Issue this PR Resolves (If Applicable).

This PR closes #XYZ.


Notes:

I might have missed something or have left over code as the files are big and work on them took a long time
If any marker is not to your liking or you found an issue with it please tell me so i could review the issue and change if needed

@Silence-112
Copy link
Copy Markdown
Member

Add images pls

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator Author

Add images pls

Added images to the pr

Copy link
Copy Markdown

@UnseenKill UnseenKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Going to take it for a test ride right now.

@wersal454
Copy link
Copy Markdown

I do dig new icons

HMG emplacement is not really representative, maybe some generic looking turret thingy?
image

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator Author

I do dig new icons

HMG emplacement is not really representative, maybe some generic looking turret thingy? image

wont work due to the small formfactor of the icon making the entire image blurry if there are details. look at radio tower for example, without the background the entire icon suffers a blur effect which make the icon look bad.

@wersal454
Copy link
Copy Markdown

image

I like the idea about having different icons for each side

As I said in dms "gives vibes and helps with distinction" imo

If most agree that one for all will do, so be it, no biggie

Also HMG emplacement icon suggestion (not an actual suggestion, just a makeup)
image

@UAC-MaxxLite
Copy link
Copy Markdown
Collaborator Author

image

I like the idea about having different icons for each side

As I said in dms "gives vibes and helps with distinction" imo

If most agree that one for all will do, so be it, no biggie

Also HMG emplacement icon suggestion (not an actual suggestion, just a makeup)
image

I already explained all the issues with the suggestion you provided.
It's way to thin, too many details. If bits will be added it would look bad and blocky. Which will make it roblox.
Further more using a weapon icon will suffer no matter what due to the same reasons.
Currently happening with the antitank marker

The different Seaport markers were a left over test for the design. If you notice details get lost yet again between each marker, which makes have 3 different versions useless.

@jwoodruff40 jwoodruff40 added this to the v11.10.0 milestone Mar 13, 2026
@Silence-112
Copy link
Copy Markdown
Member

Resolved merge conflicts, double check for errors/functionality with an ingame test @UAC-MaxxLite

@UAC-MaxxLite UAC-MaxxLite requested a review from UnseenKill March 19, 2026 22:45
private _milAdminPositions = getArray (_mapInfo/"milAdministrations");
private _milAdminMarkersToUpdate = [];

{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI: this is a prime example of why code convention three exists.

Also, question: this code will now hide markers of miladmins whose building is destroyed; this might not necessarily mean that the miladmin is cleared, though. The officer might still be alive...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mil admins are weird, at least for me.
right now mil admins dont get hidden at all, but the functionality is different, an alive mil admin wont have the hover option but a dead one will, and i cant get the hover to work on both....

UAC-MaxxLite and others added 3 commits March 20, 2026 06:54
Co-authored-by: UnseenKill <post@oliver-schieche.de>
Signed-off-by: MaxxLite <162753200+UAC-MaxxLite@users.noreply.github.com>
Co-authored-by: UnseenKill <post@oliver-schieche.de>
Signed-off-by: MaxxLite <162753200+UAC-MaxxLite@users.noreply.github.com>
Signed-off-by: UnseenKill <post@oliver-schieche.de>
UAC-MaxxLite and others added 4 commits March 20, 2026 07:09
Co-authored-by: UnseenKill <post@oliver-schieche.de>
Signed-off-by: MaxxLite <162753200+UAC-MaxxLite@users.noreply.github.com>
@UAC-MaxxLite UAC-MaxxLite requested a review from UnseenKill March 20, 2026 07:33
Copy link
Copy Markdown

@UnseenKill UnseenKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Silence-112 Silence-112 added the enhancement New feature or request label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants