Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bool-compare: support custom types #71

Merged
merged 3 commits into from
Mar 3, 2024
Merged

bool-compare: support custom types #71

merged 3 commits into from
Mar 3, 2024

Conversation

Antonboom
Copy link
Owner

Closes #65

@Antonboom Antonboom changed the title Fixes/bool compare custom types bool-compare: support custom types Mar 3, 2024
@coveralls
Copy link

coveralls commented Mar 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8131008407

Details

  • 62 of 64 (96.88%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.463%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checkers/bool_compare.go 58 60 96.67%
Totals Coverage Status
Change from base Build 8128465974: 0.1%
Covered Lines: 1689
Relevant Lines: 1788
💛 - Coveralls

@Antonboom Antonboom merged commit 68b2b3e into master Mar 3, 2024
3 checks passed
@dprotaso dprotaso mentioned this pull request Mar 8, 2024
Merged
@Antonboom Antonboom deleted the fixes/bool-compare-custom-types branch May 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

false positive: assert.True can not be used with types defined from bool
2 participants
@Antonboom @coveralls