Fixes the multiple reload shots ( https://github.com/Anuken/Mindustry/issues/11636 )#11661
Open
SomeonesShade wants to merge 3 commits intoAnuken:masterfrom
Open
Fixes the multiple reload shots ( https://github.com/Anuken/Mindustry/issues/11636 )#11661SomeonesShade wants to merge 3 commits intoAnuken:masterfrom
SomeonesShade wants to merge 3 commits intoAnuken:masterfrom
Conversation
3 tasks
Contributor
Author
|
hold up... need to fix something... |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #11636 , without reversion.
Proof of it being fixed
Broken Behavior (caused by charging or clicking multiple times)
Screen.Recording.2026-02-12.200054.mp4
Fixed Behavior
Screen.Recording.2026-02-12.200440.mp4
So... what happened?
This updated line
!wasShooting || shootWarmup < minWarmupdidn't consider that the turret can also not fire if the turret is currently warming up (my bad).It now does, and it should work.
Notes
wasShootingtracks already if the turret doesn't constantly fire,!charging()already prevents turrets that are charging like lancer to pile up reload,shootWarmup < minWarmupnow prevents warmup conditions...if(reloadShots > 0 && !charging() && shootWarmup >= minWarmup){atupdateShooting()If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: