Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update to v2 API, flatten v2 module, improve concurrency. #17

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Dec 20, 2024

Update to the chroma_cloud v2 API and in the process remove the v2
namespacing from the API. Improve concurrency as well so that there's
no contention within libssl for requests using the same
collection/client object.

Copy link
Owner

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks @rescrv.
Could you please update the snippets in the README.md to reflect the changes?

@rescrv
Copy link
Contributor Author

rescrv commented Dec 23, 2024

@Anush008 I've updated the README. Would you consider a change to include the readme at the top of lib.rs so that the docs and readme come from the same source? Something like this: https://github.com/rescrv/blue/blob/main/guacamole/src/lib.rs#L1

Update to the chroma_cloud v2 API and in the process remove the v2
namespacing from the API.  Improve concurrency as well so that there's
no contention within libssl for requests using the same
collection/client object.
@rescrv rescrv force-pushed the rescrv/upstream-v2-changes branch from 907c680 to a88e5a8 Compare December 23, 2024 17:06
@Anush008
Copy link
Owner

Anush008 commented Dec 23, 2024

Something like this: https://github.com/rescrv/blue/blob/main/guacamole/src/lib.rs#L1

👍. Thank you. That'll be cool.

@Anush008 Anush008 merged commit 3232d8a into Anush008:master Dec 30, 2024
@Anush008
Copy link
Owner

Hey @rescrv. I'll cut a release for the time being.
Thanks for taking the to contribute.

github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
# [2.0.0](v1.1.0...v2.0.0) (2024-12-30)

### Bug Fixes

* pass None when ids vector is empty for getting embeddings ([#18](#18)) ([7b6bd81](7b6bd81))

## [2.0.0](v1.1.0...v2.0.0) (2024-12-30)

### ⚠ BREAKING CHANGES

*  Update to v2 API, flatten v2 module, improve concurrency. (#17)

### 🐛 Bug Fixes

* pass None when ids vector is empty for getting embeddings ([#18](#18)) ([7b6bd81](7b6bd81))

### 📝 Documentation

* Tidy README.md ([96b256c](96b256c))

### 🧑‍💻 Code Refactoring

*  Update to v2 API, flatten v2 module, improve concurrency. ([#17](#17)) ([3232d8a](3232d8a))
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rescrv rescrv deleted the rescrv/upstream-v2-changes branch January 3, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants