feat(PushUp Model): Nicer model/movement input, slower movement (1.5s for p… #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ushup) which allows it to go much further without overloading
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the PushUp model by making the movement parameters more configurable and reducing the movement speed (from 1.0s to 1.5s) to prevent the model from overloading during push-up simulations.
Key Changes:
- Introduced configurable parameters (
Time,ChestHeightTop,ChestHeightBottom) to make the model more flexible - Refactored chest height calculations to use parametric formulas based on the new configurable values
- Updated documentation to better explain the model's strength limitations during push-up movements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| Application/Examples/PushUp/PushUp.main.any | Added configurable time and height parameters, updated study duration to use the new Time parameter, and enhanced documentation explaining model strength limitations |
| Application/Examples/PushUp/Model/JointsAndDrivers.any | Refactored chest height measurement structure, converted hard-coded values to parametric formulas using the new configuration variables, and applied consistent formatting to assignment operators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: M. Damsgaard <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: M. Damsgaard <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
melund
changed the title
melund
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ushup) which allows it to go much further without overloading