fix: avoid python calls, since we have observed the python instabilities in latest version of AMS #1116
Conversation
…ies in latest version of AMS
| #endif | ||
| #endif | ||
| #endif | ||
| // // Trigger check for read-only AMMR if we think user is running |
There was a problem hiding this comment.
Is it the intention to activate this code again when the instability is resolved ?
Could we use the ams version to keep the check for versions below the affected one ?
There was a problem hiding this comment.
Yes. This was my idea. I have only seen the problem a few times on my machine, but I really don't want this to hit random users.
Could we use the ams version to keep the check for versions below the affected one ?
I don't think that is necessary.
Right now, it still calls python if we run AMMR from a Git repo - An other python hook which gets the git-info. I could also disable that by switching the BM configuration. But it would hit some of our models/pipelines which expect it to be there. But that would also only affect advanced users.
There was a problem hiding this comment.
Thanks for explaining - let's leave it as-is then :)
No description provided.