add ethereum conversion function #155
Conversation
eth/web3.c
Outdated
|
|
||
| // add zeros | ||
| if (from >= to) { | ||
| set256_uint64(&power, pow(10, (int) from - (int) to)); |
There was a problem hiding this comment.
you can't really use pow() here since embedded systems can't use floats
There was a problem hiding this comment.
Since the custom pow function can't be built without using uint128_t (2 ^ 64 < 30) I used simple string manipulation for the eth_convert function, it's more efficient.
pcppcp
left a comment
pcppcp
left a comment
There was a problem hiding this comment.
looks good, please fix the magic numbers and add some test where the function is expected to fail and it's good to merge.
eth/web3.c
Outdated
| return -1; | ||
| } | ||
| // move numbers | ||
| for (i = len + 1 + 1; i > len - shift; --i) { |
There was a problem hiding this comment.
One nitpick - could you replace magic numbers in string length calculation with defines? It will make it easier to read and understand.
i.e. here it would look like for (i = len + DECIMAL_POINT + SOMETHING; i > len - shift; --i)
Signed-off-by: Mislav Novakovic <[email protected]>
|
@pcppcp do you want me to do any other changes? |
2 participants
Hi,
I implemented the
eth_convertfunction described in #97, I tried to use as much as possible the uint256_t functions, but now the code is a bit clunky and I'm not sure if I should simply convert the number to a string and simply add a.and move the number as strings around.Signed-off-by: Mislav Novakovic [email protected]