feat: Add support for optimizer compiler args#162
Open
MarcBickel wants to merge 1 commit into
Open
Conversation
Author
|
I am not sure on how to actually test this properly, I would love some help for writing them. |
fubuloubu
approved these changes
May 2, 2025
Member
There is a temporary config method @antazoey introduced so you can modify config for testing |
fubuloubu
reviewed
May 2, 2025
| """Yul optimization and steps are not supported for this version of solc | ||
| (Need >= 0.8.22).""" | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
I think this likely needs some changes up here https://github.com/ApeWorX/ape-solidity/pull/162/files#diff-de61acbec749a43c9ae1590d091b2924af42588fa689b9cef657a9e02f39e016R359
Maybe move it here to be:
Suggested change
| else: | |
| version_settings["optimzer"].update({"enabled": config.optimize, "runs": config.optimization_runs}) | |
(Also remove the setting above it and change the type hint for version_settings to just dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
fixes: Compilation arguments not being precise enough for optimizer
How I did it
How to verify it
Checklist