perf: use cached chain ID when possible instead of re-looking up from provider #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Had a weird "snapshot ID not found" bug, retrying... |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
fubuloubu
previously approved these changes
Nov 23, 2025
fubuloubu
previously approved these changes
Nov 23, 2025
fubuloubu
force-pushed
the
fix/use-cached-chainid
branch
2 times, most recently
from
989ec47 to
acdd70c
Compare
fubuloubu
previously approved these changes
Nov 24, 2025
fubuloubu
force-pushed
the
fix/use-cached-chainid
branch
from
cce9c7a to
811ee77
Compare
fubuloubu
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I noticed several spots where we were calling
.provider.chain_idinstead of using the cached one fromchain_manager.chain_id.This should lessen some RPC calls I would think.
How I did it
How to verify it
Checklist