-
Notifications
You must be signed in to change notification settings - Fork 291
Implement tls support for the app #6007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
operator/controller/src/main/java/io/apicurio/registry/operator/feat/TLS.java
Show resolved
Hide resolved
operator/controller/src/main/java/io/apicurio/registry/operator/feat/TLS.java
Show resolved
Hide resolved
6e93999
to
7fadf42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but have some questions. Some of the comments are optional/can be done later.
operator/controller/src/main/java/io/apicurio/registry/operator/feat/TLS.java
Outdated
Show resolved
Hide resolved
operator/controller/src/main/java/io/apicurio/registry/operator/resource/ResourceFactory.java
Show resolved
Hide resolved
operator/controller/src/main/java/io/apicurio/registry/operator/resource/ResourceFactory.java
Outdated
Show resolved
Hide resolved
operator/controller/src/main/java/io/apicurio/registry/operator/EnvironmentVariables.java
Outdated
Show resolved
Hide resolved
operator/controller/src/main/java/io/apicurio/registry/operator/feat/TLS.java
Show resolved
Hide resolved
operator/controller/src/main/java/io/apicurio/registry/operator/resource/ResourceFactory.java
Outdated
Show resolved
Hide resolved
operator/controller/src/test/java/io/apicurio/registry/operator/it/TlsITTest.java
Show resolved
Hide resolved
operator/controller/src/test/java/io/apicurio/registry/operator/it/TlsITTest.java
Outdated
Show resolved
Hide resolved
operator/controller/src/test/java/io/apicurio/registry/operator/it/TlsITTest.java
Outdated
Show resolved
Hide resolved
...troller/src/test/resources/k8s/examples/tls/insecure-traffic-with_tls.apicurioregistry3.yaml
Outdated
Show resolved
Hide resolved
00157d1
to
f81da02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are still some suggested changes, but no blockers.
No description provided.