Collector 0.2.0 #1
Conversation
PSchmiedmayer
left a comment
PSchmiedmayer
left a comment
There was a problem hiding this comment.
@pauljohanneskraft Thanks for the improvements to Collector!
I have changed the GitHub Action to use the latest Xcode beta (13.2) to get the tests running It supports building and testing Swift Concurrency features for older os versions. There are still some issues as listed in Apodini/Apodini#374 but that doesn't affect this PR as you don't use any Swift Concurrency features in the test targets. So changing xcode-version: latest-stable to xcode-version: latest in the regular builds should be fine for new.
Codecov Report
@@ Coverage Diff @@
## develop #1 +/- ##
==========================================
- Coverage 1.23% 0.60% -0.64%
==========================================
Files 10 17 +7
Lines 162 666 +504
==========================================
+ Hits 2 4 +2
- Misses 160 662 +502
Continue to review full report at Codecov.
|
|
@pauljohanneskraft You also have the permissions to merge the PR despite the SwiftLint warnings and CodeCov reports once you feel the PR is ready. All important builds seem to pass now 🚀 |
Collector 0.2.0
♻️ Current situation
There is no way to only collect metrics or traces. You always get both features at once without the choice of one.
Dependencies should only be part of a framework, if they are essential to them - which is not the case for NIO in MetricCollector.
There is no way of injecting/extracting context from a Foundation URLRequest.
💡 Proposed solution
Separate Collector into MetricCollector and TraceCollector with only relevant dependencies between the two. Collector is still a package that can be imported (essentially MetricCollector + TraceCollector).
Remove direct dependency on NIO for MetricCollector. We still have it in the list through SwiftPrometheus though.
Add Context Propagation for URLRequest right in the main repository.
Implications
Minor interface changes from NIO to async/await.
Testing
There are no tests so far.
Reviewer Nudging
The changes are actually quite minor, so you should be able to skim over all of them.