Add units to LATENCY_GAUGE #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for not getting to this pull request sooner, it's difficult to understand your motives without a description. Can you explain the reason you need to add this parameter, was there an issue without it? |
|
Hey! Not a problem! There isn't a problem. This works fine; this just adds a units flag to the Prometheus entry. Thanks for the sample code btw! It's really helped up my bot's monitoring |
|
All good, I'll be merging this. The dashboard will need to be updated since this changes the metric name from |
|
Version 0.2.0 is up with your changes, make sure to update your dashboards. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.