Conversation
Contributor
Author
|
Replying to say Don't merge this! Just got this bug report. Tracked it down to find out that the culprit is the ScreenAreaRatio, which doesn't work as expected when Windows has its scaling level above 100%. GetSystemMetrics gets the scaled resolution while the Wacom Driver gets the real resolution.. |
Contributor
Author
|
Reopening until I'm certain it's not an easy fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Edit: Clarity. Also, I had said something about EasyTab not working with multiple monitors, which wasn't true! EasyTab was working, but setting the whole monitor as the output area. ]
This implements support for screen area mapping, which means not setting the SysOrg and SysExt variables in LogContext.
Looking at lines 895 and 896 of the PR:
when before it was:
This should work as before when the feature is not being used.
I tested it on my machine enabling only one monitor and toggling the feature, but please test it if you choose to merge this :)
The feature works as expected with Milton compared with other programs that support it (Krita, Mischief, Gimp) but I have only tried it out with Milton. Maybe test it with Papaya first?
Finally, requesting code review :)