Update index.html #8267
Open
Update index.html #8267
+69
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR refactors index.html to streamline PWA metadata, update branding, add a loading spinner, and tweak the service worker bootstrap logic to hide the spinner once the app loads. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
|
updated html |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Reintroduce a timeout fallback to load main.dart.js in case service worker registration stalls, so the loading spinner doesn’t persist indefinitely.
- Extract the inline spinner CSS into a separate stylesheet or component to keep styles modular and themeable.
- Include a comment or script to dynamically set when deploying under a subpath, since that configuration was removed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Reintroduce a timeout fallback to load main.dart.js in case service worker registration stalls, so the loading spinner doesn’t persist indefinitely.
- Extract the inline spinner CSS into a separate stylesheet or component to keep styles modular and themeable.
- Include a comment or script to dynamically set <base href> when deploying under a subpath, since that configuration was removed.
## Individual Comments
### Comment 1
<location> `frontend/appflowy_flutter/web/index.html:56` </location>
<code_context>
+
+ function loadMainDartJs() {
+ // NEW: Hide indicator before starting the main Dart script load
+ hideLoadingIndicator();
+
+ if (scriptLoaded) {
</code_context>
<issue_to_address>
**suggestion (bug_risk):** The loading indicator is hidden before the main Dart script is loaded, which may cause a brief flash of uninitialized UI.
Hide the loading indicator after the Dart script has loaded and the app is initialized to prevent users from seeing incomplete UI.
Suggested implementation:
```
function loadMainDartJs() {
// Hide indicator AFTER the main Dart script has loaded and app is initialized
if (scriptLoaded) {
return;
}
scriptLoaded = true;
var scriptTag = document.createElement('script');
scriptTag.src = 'main.dart.js';
scriptTag.type = 'application/javascript';
scriptTag.addEventListener('load', function() {
// Optionally, you may want to wait for Dart app initialization here
hideLoadingIndicator();
});
document.body.append(scriptTag);
}
```
If your Dart app exposes a global callback or event for when initialization is complete (e.g., `window.flutterAppInitialized`), you should call `hideLoadingIndicator()` in that callback instead of the script's `load` event. Adjust as needed for your app's initialization flow.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| function loadMainDartJs() { | ||
| // NEW: Hide indicator before starting the main Dart script load | ||
| hideLoadingIndicator(); |
There was a problem hiding this comment.
suggestion (bug_risk): The loading indicator is hidden before the main Dart script is loaded, which may cause a brief flash of uninitialized UI.
Hide the loading indicator after the Dart script has loaded and the app is initialized to prevent users from seeing incomplete UI.
Suggested implementation:
function loadMainDartJs() {
// Hide indicator AFTER the main Dart script has loaded and app is initialized
if (scriptLoaded) {
return;
}
scriptLoaded = true;
var scriptTag = document.createElement('script');
scriptTag.src = 'main.dart.js';
scriptTag.type = 'application/javascript';
scriptTag.addEventListener('load', function() {
// Optionally, you may want to wait for Dart app initialization here
hideLoadingIndicator();
});
document.body.append(scriptTag);
}
If your Dart app exposes a global callback or event for when initialization is complete (e.g., window.flutterAppInitialized), you should call hideLoadingIndicator() in that callback instead of the script's load event. Adjust as needed for your app's initialization flow.
|
updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Revamp the web entrypoint index.html to apply AppFlowy branding, streamline meta tags, and enhance the user experience with a CSS-based loading spinner that is hidden once the main Flutter script loads.
Enhancements: