Skip to content

Conversation

HARISHVIJAY006
Copy link

@HARISHVIJAY006 HARISHVIJAY006 commented Oct 9, 2025

change in Front page of the Flutter page and it gets loaded

Summary by Sourcery

Redesign the Flutter web index.html by updating metadata, adding a styled loading screen, and switching to the flutter.js loader for streamlined app initialization

New Features:

  • Add custom loading screen with logo, animated spinner, and loading text

Enhancements:

  • Update HTML metadata (lang attribute, viewport, description, title, and manifest links)
  • Replace manual service worker logic with flutter.js loader entrypoint and streamline app bootstrap
  • Simplify base href to root path

Copy link
Contributor

sourcery-ai bot commented Oct 9, 2025

Reviewer's Guide

This PR refactors the Flutter web entrypoint by enriching the HTML head for accessibility and PWA support, introducing a custom loading screen with CSS animations, and replacing the old service‐worker bootstrap script with the official flutter.js loader.

Sequence diagram for new Flutter web bootstrap process

sequenceDiagram
  actor User
  participant Browser
  participant "flutter.js loader"
  participant "Flutter Engine"
  User->>Browser: Load AppFlowy Flutter web page
  Browser->>"flutter.js loader": Load flutter.js
  "flutter.js loader"->>"Flutter Engine": Initialize engine
  "Flutter Engine"-->>"flutter.js loader": Engine initialized
  "flutter.js loader"->>Browser: Remove loading screen
  "flutter.js loader"->>"Flutter Engine": Run app
  "Flutter Engine"->>User: Display Flutter app
Loading

File-Level Changes

Change Details Files
Enhanced HTML head metadata and PWA assets
  • Added lang="en" on tag
  • Set base href to "/" and updated viewport and description meta tags
  • Reordered title, manifest, and apple-touch-icon declarations
frontend/appflowy_flutter/web/index.html
Introduced custom loading screen and styles
  • Inlined CSS for body layout, spinner, logo fade-in, and text pulse animations
  • Added loading-container HTML with logo, spinner, and loading text
frontend/appflowy_flutter/web/index.html
Replaced manual service worker script with flutter.js bootstrap
  • Removed legacy service-worker registration and fallback logic
  • Added deferred flutter.js loader and onEntrypointLoaded engine initializer
  • Removed loading screen upon engine initialization and invoked runApp()
frontend/appflowy_flutter/web/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@HARISHVIJAY006
Copy link
Author

This pull request updates the index.html file of the Flutter web app to enhance the loading experience and improve initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants