-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New Update document_toolbar_test.dart #8281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR refactors the document_toolbar integration tests by removing redundant blank lines for cleaner formatting and extends link-handling coverage with a new test that verifies styled text attributes are preserved through link insertion and removal. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- There are stray placeholder lines (e.g. “Expand Down”, “Expand Up”) and duplicated blocks near the end of the file—please remove those to restore valid Dart syntax.
- The new ‘getAttribute’ logic and other selection helpers are duplicated—consider moving them into a shared test utility to reduce boilerplate.
- The heading and toggle tests follow almost identical patterns; try parameterizing them in a loop or table-driven approach to make the code more concise and maintainable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are stray placeholder lines (e.g. “Expand Down”, “Expand Up”) and duplicated blocks near the end of the file—please remove those to restore valid Dart syntax.
- The new ‘getAttribute’ logic and other selection helpers are duplicated—consider moving them into a shared test utility to reduce boilerplate.
- The heading and toggle tests follow almost identical patterns; try parameterizing them in a loop or table-driven approach to make the code more concise and maintainable.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Refine document_toolbar integration tests by cleaning up formatting and adding a new test to ensure text styles persist through link insertion and removal.
Enhancements:
Tests: