-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New Update document_alignment_test.dart #8282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR completely refactors the integration test suite in document_alignment_test.dart by removing legacy alignment tests, updating imports to support localization and file system operations, and introducing new test groups that validate template UI options, export functionality (template.zip, config.json, CSV), and import behavior with view hierarchy verification. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Ensure that files and directories created in getApplicationDocumentsDirectory are cleaned up between tests (or use a temporary directory) to avoid side-effects and flaky runs.
- Consider mocking the file system or injecting a fake path_provider to isolate tests from the real device storage and speed up I/O operations.
- You can reduce boilerplate by moving repeated _initTest calls and common setup into a setUp function at the top of each test group.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that files and directories created in getApplicationDocumentsDirectory are cleaned up between tests (or use a temporary directory) to avoid side-effects and flaky runs.
- Consider mocking the file system or injecting a fake path_provider to isolate tests from the real device storage and speed up I/O operations.
- You can reduce boilerplate by moving repeated _initTest calls and common setup into a setUp function at the top of each test group.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
Feature Preview
PR Checklist
Summary by Sourcery
Add comprehensive integration tests for the template feature, covering UI presence, export file generation, and import behavior for both document and grid templates.
Enhancements:
Tests: