Skip to content

Conversation

Madhuz02
Copy link

@Madhuz02 Madhuz02 commented Oct 10, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Improve the build script by adding console output that indicates whether Dart protobuf code generation is running or being skipped based on the Dart feature flag

Build:

  • Add informative logging in build.rs for Dart protobuf code generation
  • Print a message when Dart feature is not enabled, skipping code generation

Copy link
Contributor

sourcery-ai bot commented Oct 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhance build.rs in the flowy-error crate to add informative logging around Dart protobuf code generation and handle the case when the Dart feature is not enabled.

Flow diagram for updated build.rs Dart code generation logic

flowchart TD
    A["Start build.rs"] --> B{"Is 'dart' feature enabled?"}
    B -- Yes --> C["Print: Generating Dart protobuf code for package" ]
    C --> D["Call dart_gen with package name"]
    B -- No --> E["Print: Dart feature not enabled; skipping code generation."]
Loading

File-Level Changes

Change Details Files
Add detailed logging to the Dart code generation path
  • Wrap generation logic in its own block
  • Print a start message with package name
  • Call dart_gen with env package
frontend/rust-lib/flowy-error/build.rs
Handle non-Dart feature case with skip log
  • Add cfg(not(feature = "dart")) block
  • Print a skipping message when Dart feature isn’t enabled
frontend/rust-lib/flowy-error/build.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `frontend/rust-lib/flowy-error/build.rs:8-11` </location>
<code_context>
+        flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME"));
+    }
+
+    #[cfg(not(feature = "dart"))]
+    {
+        println!("Dart feature not enabled; skipping code generation.");
+    }
 }
</code_context>

<issue_to_address>
**suggestion:** The message for skipping code generation may be unnecessary noise.

Consider removing this print statement or making it conditional on a verbose/debug flag to avoid unnecessary output during normal builds.

```suggestion
    #[cfg(not(feature = "dart"))]
    {
        if std::env::var("FLOWY_VERBOSE").is_ok() || std::env::var("FLOWY_DEBUG").is_ok() {
            println!("Dart feature not enabled; skipping code generation.");
        }
    }
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants