-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New Update build.rs #8284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New Update build.rs #8284
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhance build.rs in the flowy-error crate to add informative logging around Dart protobuf code generation and handle the case when the Dart feature is not enabled. Flow diagram for updated build.rs Dart code generation logicflowchart TD
A["Start build.rs"] --> B{"Is 'dart' feature enabled?"}
B -- Yes --> C["Print: Generating Dart protobuf code for package" ]
C --> D["Call dart_gen with package name"]
B -- No --> E["Print: Dart feature not enabled; skipping code generation."]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `frontend/rust-lib/flowy-error/build.rs:8-11` </location>
<code_context>
+ flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME"));
+ }
+
+ #[cfg(not(feature = "dart"))]
+ {
+ println!("Dart feature not enabled; skipping code generation.");
+ }
}
</code_context>
<issue_to_address>
**suggestion:** The message for skipping code generation may be unnecessary noise.
Consider removing this print statement or making it conditional on a verbose/debug flag to avoid unnecessary output during normal builds.
```suggestion
#[cfg(not(feature = "dart"))]
{
if std::env::var("FLOWY_VERBOSE").is_ok() || std::env::var("FLOWY_DEBUG").is_ok() {
println!("Dart feature not enabled; skipping code generation.");
}
}
```
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Improve the build script by adding console output that indicates whether Dart protobuf code generation is running or being skipped based on the Dart feature flag
Build: