-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
set autoFocus true for font dropdown search input #8294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the font family dropdown so that its search input receives focus automatically when the dropdown opens by toggling the autoFocus flag. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key: ThemeFontFamilySetting.textFieldKey, | ||
hintText: LocaleKeys.settings_appearance_fontFamily_search.tr(), | ||
autoFocus: false, | ||
autoFocus: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why it cannot be passed as widget paramethers
Feature Preview
this PR fix the font name input field is not focused issue #8290
fixes #8290
Before:
beforefix.mp4
After:
afterfix.mp4
What this PR does:
This PR fixes the font family dropdown in AppFlowy so that the font name input field is auto-focused by default when the dropdown opens.
Before this fix, typing immediately after opening the font menu would accidentally replace the selected text in the document instead of entering the font name in the search field.
This PR changes the autoFocus property of the font family search input in the dropdown from false to true.
PR Checklist
Summary by Sourcery
Bug Fixes: