feat: add OIDC/SSO enterprise login support#8713
Open
giutrec wants to merge 2 commits into
Open
Conversation
- Modified frontend/rust-lib/Cargo.toml to include patch for AppFlowy-Cloud. - Added Saml and Oidc variants to ProviderTypePB enum in frontend/rust-lib/flowy-user/src/entities/auth.rs. - Mapped 'sso' to ProviderTypePB.Oidc in af_cloud_auth_service.dart. - Added 'sso' variant to ThirdPartySignInButtonType enum and updated UI components. - Integrated SSO login button into the sign-in screens. - Ignored build_dockers.sh in .gitignore.
Contributor
Reviewer's GuideAdds enterprise SSO (OIDC) login support end-to-end by wiring a new SSO provider type from Rust auth entities through Flutter auth services and UI, plus pointing the Rust client to local AppFlowy-Cloud patches and ignoring a local Docker helper script. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The SSO button label is hardcoded as
'Enterprise Login (SSO)'instead of using a localized key like the other providers; consider adding aLocaleKeysentry for this string to keep i18n consistent. - The new SSO button is always rendered on both desktop and mobile; if SSO is only available in certain deployments or behind a feature flag, consider conditionally showing this button based on configuration or server capabilities.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The SSO button label is hardcoded as `'Enterprise Login (SSO)'` instead of using a localized key like the other providers; consider adding a `LocaleKeys` entry for this string to keep i18n consistent.
- The new SSO button is always rendered on both desktop and mobile; if SSO is only available in certain deployments or behind a feature flag, consider conditionally showing this button based on configuration or server capabilities.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 29 | warning | contribute (via Fink 🐦) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Add support for enterprise SSO/OIDC login across frontend and Rust user auth, including wiring the new provider type through the sign-in UI and auth service.
New Features:
Enhancements:
Chores: