Skip to content

fix: prevent crash when mobile workspace list is empty#8753

Open
hitesh358-str wants to merge 1 commit into
AppFlowy-IO:mainfrom
hitesh358-str:fix/mobile-empty-workspace-crash
Open

fix: prevent crash when mobile workspace list is empty#8753
hitesh358-str wants to merge 1 commit into
AppFlowy-IO:mainfrom
hitesh358-str:fix/mobile-empty-workspace-crash

Conversation

@hitesh358-str

@hitesh358-str hitesh358-str commented May 23, 2026

Copy link
Copy Markdown

Summary

This PR prevents a crash in MobileWorkspaceStartScreen when the workspace list is empty.

Root Cause

The Get Started button accessed:

widget.workspaceState.workspaces.first

when selectedWorkspace == null.

If the workspace list was empty, this caused:

Bad state: No element

Changes

  • Added a guard to check whether workspaces exist
  • Disabled the Get Started button when workspace list is empty
  • Preserved existing behavior when workspaces are available
  • Added widget test coverage for the empty workspace state

Testing

  • Verified normal flow when workspace exists
  • Verified button becomes disabled when workspace list is empty
  • Verified no .first access occurs on empty lists

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Prevent MobileWorkspaceStartScreen from crashing when the workspace list is empty and add coverage for the empty state.

Bug Fixes:

  • Disable the Get Started action when there are no workspaces to avoid accessing the first element of an empty list.

Tests:

  • Add a widget test ensuring the Get Started button is disabled when the workspace list is empty.

@CLAassistant

CLAassistant commented May 23, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sourcery-ai

sourcery-ai Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In the widget test, consider using a more specific finder (e.g., by text or a key) instead of find.byType(ElevatedButton) to avoid brittleness if additional buttons are added to the screen in the future.
  • The onPressed logic in MobileWorkspaceStartScreen’s ElevatedButton is starting to get a bit dense; consider extracting the workspace-selection and _popToWorkspace decision into a small helper method to keep the build method easier to scan.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the widget test, consider using a more specific finder (e.g., by text or a key) instead of `find.byType(ElevatedButton)` to avoid brittleness if additional buttons are added to the screen in the future.
- The `onPressed` logic in `MobileWorkspaceStartScreen`’s `ElevatedButton` is starting to get a bit dense; consider extracting the workspace-selection and `_popToWorkspace` decision into a small helper method to keep the `build` method easier to scan.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants