Skip to content

feat: support expanding/collapsing toggle list in read-only mode #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ramrajnagar wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −5
Open

feat: support expanding/collapsing toggle list in read-only mode #8755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5ac4e8
feat: support expanding/collapsing toggle list in read-only mode
May 24, 2026
25e7287
fix: reset _readOnlyCollapsed on external attribute changes
May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions ...utter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,26 @@ class _ToggleListBlockComponentWidgetState

bool get collapsed => node.attributes[ToggleListBlockKeys.collapsed] ?? false;

bool? _readOnlyCollapsed;

bool get _effectiveCollapsed => _readOnlyCollapsed ?? collapsed;

int? get level => node.attributes[ToggleListBlockKeys.level] as int?;

@override
void didUpdateWidget(ToggleListBlockComponentWidget oldWidget) {
super.didUpdateWidget(oldWidget);
final oldCollapsed =
oldWidget.node.attributes[ToggleListBlockKeys.collapsed] as bool? ??
false;
if (oldCollapsed != collapsed) {
_readOnlyCollapsed = null;
}
}

@override
Widget build(BuildContext context) {
return collapsed
return _effectiveCollapsed
? buildComponent(context)
: buildComponentWithChildren(context);
}
Expand Down Expand Up @@ -241,7 +256,7 @@ class _ToggleListBlockComponentWidgetState
child: Container(
key: blockComponentKey,
color: withBackgroundColor ||
(backgroundColor != Colors.transparent && collapsed)
(backgroundColor != Colors.transparent && _effectiveCollapsed)
? backgroundColor
: null,
child: child,
Expand Down Expand Up @@ -295,7 +310,7 @@ class _ToggleListBlockComponentWidgetState
Widget _buildPlaceholder() {
// if the toggle block is collapsed or it contains children, don't show the
// placeholder.
if (collapsed || node.children.isNotEmpty) {
if (_effectiveCollapsed || node.children.isNotEmpty) {
return const SizedBox.shrink();
}

Expand Down Expand Up @@ -375,8 +390,8 @@ class _ToggleListBlockComponentWidgetState
}

final turns = switch (textDirection) {
TextDirection.ltr => collapsed ? 0.0 : 0.25,
TextDirection.rtl => collapsed ? -0.5 : -0.75,
TextDirection.ltr => _effectiveCollapsed ? 0.0 : 0.25,
TextDirection.rtl => _effectiveCollapsed ? -0.5 : -0.75,
};

return Container(
Expand All @@ -402,6 +417,12 @@ class _ToggleListBlockComponentWidgetState
}

Future<void> onCollapsed() async {
if (!editorState.editable) {
setState(() {
_readOnlyCollapsed = !_effectiveCollapsed;
});
return;
}
final transaction = editorState.transaction
..updateNode(node, {
ToggleListBlockKeys.collapsed: !collapsed,
Expand Down
Loading