fix(ui): resolve vertical overflow in DatePicker components by adjust…#8758
Open
EmirSamur wants to merge 2 commits into
Open
fix(ui): resolve vertical overflow in DatePicker components by adjust…#8758EmirSamur wants to merge 2 commits into
EmirSamur wants to merge 2 commits into
Conversation
…ing row height and text clipping
Contributor
Reviewer's GuideAdjusts DatePicker desktop calendar layout to prevent vertical overflow and improve robustness of day-of-week labels, and adds leak-tracking dependency overrides for tests. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The inline comments added to
_CalendarStyle.desktopanddowBuilderare currently in Turkish; consider either removing them or rewriting them in English to keep codebase comments consistent and understandable for all contributors. - Using
anyfor theleak_trackerandleak_tracker_flutter_testingdependency_overrides inpubspec.yamlmay introduce unexpected breakages over time; it would be safer to pin them to specific versions or limit these overrides to local development instead of committing them.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline comments added to `_CalendarStyle.desktop` and `dowBuilder` are currently in Turkish; consider either removing them or rewriting them in English to keep codebase comments consistent and understandable for all contributors.
- Using `any` for the `leak_tracker` and `leak_tracker_flutter_testing` dependency_overrides in `pubspec.yaml` may introduce unexpected breakages over time; it would be safer to pin them to specific versions or limit these overrides to local development instead of committing them.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts the date picker calendar layout to reduce header overflow and adds dependency overrides to address leak_tracker package resolution.
Changes:
- Add
leak_trackerandleak_tracker_flutter_testingtodependency_overrides. - Update day-of-week (DOW) header rendering to reduce vertical padding and prevent text overflow.
- Increase desktop calendar row height for improved spacing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/appflowy_flutter/pubspec.yaml | Adds dependency overrides for leak tracker packages. |
| frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_picker.dart | Tweaks calendar header text rendering and desktop row sizing to avoid overflow/tight layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+177
to
+178
| leak_tracker: any | ||
| leak_tracker_flutter_testing: any |
| final locale = context.locale.toLanguageTag(); | ||
| final label = DateFormat.E(locale).format(day); | ||
| return Padding( | ||
| padding: const EdgeInsets.only(bottom: 4.0), // 8.0'den 4.0'e çektik ki dikey alan rahatlasın |
Comment on lines
+140
to
+141
| maxLines: 1, // Taşmayı engelleyecek kural 1 | ||
| overflow: TextOverflow.ellipsis, // Taşmayı engelleyecek kural 2 |
Comment on lines
+131
to
+146
| dowBuilder: (context, day) { | ||
| final locale = context.locale.toLanguageTag(); | ||
| final label = DateFormat.E(locale).format(day); | ||
| return Padding( | ||
| padding: const EdgeInsets.only(bottom: 4.0), // 8.0'den 4.0'e çektik ki dikey alan rahatlasın | ||
| child: Center( | ||
| child: Text( | ||
| label, | ||
| style: calendarStyle.dowTextStyle, | ||
| maxLines: 1, // Taşmayı engelleyecek kural 1 | ||
| overflow: TextOverflow.ellipsis, // Taşmayı engelleyecek kural 2 | ||
| ), | ||
| ), | ||
| ); | ||
| }, | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the vertical overflow issue in the
DatePickercomponent.Changes
rowHeightfrom33to38in_CalendarStyle.desktopto provide adequate vertical breathing room for grid cells.maxLines: 1andoverflow: TextOverflow.ellipsisto theTextwidget insidedowBuilderto gracefully handle localized or system-enlarged text without breaking the layout.Context
This contribution is also part of my open-source software university course final project. Feedback is highly appreciated!
Summary by Sourcery
Adjust DatePicker calendar layout to prevent vertical overflow in desktop view and improve handling of long weekday labels.
Bug Fixes:
Build: