fix: swap officialVersion labels between en-US and zh-TW translations#8815
Open
its-me wants to merge 1 commit into
Open
fix: swap officialVersion labels between en-US and zh-TW translations#8815its-me wants to merge 1 commit into
its-me wants to merge 1 commit into
Conversation
en-US.json had the Chinese string 官方構建 where "Official build" belongs, and zh-TW.json had "Official build" where 官方構建 belongs. Swap them to the correct locales.
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR corrects the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Identical pattern | 1 | warning | contribute (via Fink 🐦) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
officialVersiontranslation strings inen-US.jsonandzh-TW.jsonare swapped:en-US.jsonVersion {version} (官方構建)Version {version} (Official build)zh-TW.json版本 {version} (Official build)版本 {version} (官方構建)English-locale users see a Chinese string in the About dialog, and Traditional Chinese users see an English string — the labels were placed in the wrong locale files.
How to reproduce
Build AppFlowy with an English locale and open Settings → About AppFlowy. The version line shows
Version x.y.z (官方構建)instead ofVersion x.y.z (Official build).Summary by Sourcery
Bug Fixes:
officialVersiontranslation strings between en-US and zh-TW so each locale displays the correct language label.