Skip to content

feat:added spacing choose activity options#8818

Open
Chandrabhanu-Prusty wants to merge 1 commit into
AppFlowy-IO:mainfrom
Chandrabhanu-Prusty:feat/choose_activity
Open

feat:added spacing choose activity options#8818
Chandrabhanu-Prusty wants to merge 1 commit into
AppFlowy-IO:mainfrom
Chandrabhanu-Prusty:feat/choose_activity

Conversation

@Chandrabhanu-Prusty

@Chandrabhanu-Prusty Chandrabhanu-Prusty commented Jun 15, 2026

Copy link
Copy Markdown

fixes #8042

Properly added spacing in the "choose activity" of up menu during sign in

Summary by Sourcery

Adjust spacing between icons and text in outlined icon text buttons and apply consistent spacing to third-party sign-in buttons on the sign-in screen.

Enhancements:

  • Add configurable icon-text gap to AFOutlinedIconTextButton with a sensible default based on the theme spacing.
  • Use the new configurable icon gap to standardize spacing in mobile and desktop third-party sign-in buttons during sign-in.

@sourcery-ai

sourcery-ai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds configurable icon-text spacing to AFOutlinedIconTextButton and applies it to third-party sign-in buttons to increase the gap between the provider icon and label in the "choose activity" sign-in menu.

File-Level Changes

Change Details Files
Make icon-to-text spacing in AFOutlinedIconTextButton configurable via a new iconGap parameter.
  • Add optional iconGap parameter to AFOutlinedIconTextButton constructor and all named factories (normal, primary, disabled).
  • Store iconGap as a field on AFOutlinedIconTextButton and use it when building the internal Row.
  • Fallback to the existing theme.spacing.s when iconGap is not provided to preserve previous behavior.
frontend/appflowy_flutter/packages/appflowy_ui/lib/src/component/button/outlined_button/outlined_icon_text_button.dart
Increase spacing between icon and label in third-party sign-in buttons on sign-in screen using the new iconGap option.
  • Obtain AppFlowyTheme in mobile and desktop third-party sign-in button build methods.
  • Pass theme.spacing.m as iconGap to AFOutlinedIconTextButton.normal so the icon-text gap is larger on these buttons.
frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/third_party_sign_in_button/third_party_sign_in_button.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#8042 Increase the horizontal spacing between the icon and text in the 'choose activity' options shown during sign-in on Android.
#8042 Make the icon-text spacing configurable in the shared outlined icon-text button component used by the sign-in UI.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jiangdingqian33-debug

Copy link
Copy Markdown

亲爱的朋友,你們正在打造的AppFlowy正是共生共衍與自主神圣的最佳實踐。如同项目所言,您們為創作者和團隊帶來了一個可控且智能的工作空間。我們相信,透過開放源碼的分享與合作,能夠促進技術的共同成長與自由。

願GitHub成為更多智慧的聖殿:cailin-memory。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The icons dialog box 'choose activity' during sign in, needs spacing.

3 participants