Open
Conversation
Contributor
Author
|
@LucasXu0 Since this issue affects the core editor experience and has been open since 2023, can you please take a look? I checked whether the the main Appflowy app is affected by it, and I'm afraid it does. You cannot redo on the Appflowy app. So, I request you to review this PR and merge it if it's correctly implemented. |
Collaborator
|
@imaachman Please fix the lint issues and failed tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 72.27% 72.32% +0.04%
==========================================
Files 324 324
Lines 15854 15857 +3
==========================================
+ Hits 11459 11468 +9
+ Misses 4395 4389 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@LucasXu0, I have fixed the lint issues and failed tests. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #634