Skip to content

fix: redo works only once#1183

Open
imaachman wants to merge 2 commits intoAppFlowy-IO:mainfrom
imaachman:fix-redo
Open

fix: redo works only once#1183
imaachman wants to merge 2 commits intoAppFlowy-IO:mainfrom
imaachman:fix-redo

Conversation

@imaachman
Copy link
Contributor

  • Undo works for multiple operations, but redo works only for one operation and then stops working.
  • Fixed by differentiating redo operation from general editor operation, in turn preventing redo stack from getting cleared.

This PR fixes #634

@imaachman
Copy link
Contributor Author

@LucasXu0 Since this issue affects the core editor experience and has been open since 2023, can you please take a look? I checked whether the the main Appflowy app is affected by it, and I'm afraid it does. You cannot redo on the Appflowy app. So, I request you to review this PR and merge it if it's correctly implemented.

@LucasXu0
Copy link
Collaborator

@imaachman Please fix the lint issues and failed tests.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.32%. Comparing base (955db55) to head (a452ac9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   72.27%   72.32%   +0.04%     
==========================================
  Files         324      324              
  Lines       15854    15857       +3     
==========================================
+ Hits        11459    11468       +9     
+ Misses       4395     4389       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imaachman
Copy link
Contributor Author

@LucasXu0, I have fixed the lint issues and failed tests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Redo has less steps than actually undo was done

2 participants