Skip to content

Check if the active course reviews are completed instead of all course reviews #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DylanApardian
Copy link
Contributor

⁉️ Related Issue

#1161

📖 Description

The allReviewsCompleted flag in course.dart now checks if all the active course reviews have been completed.
An active course review represents a course review which the startAt date is before the current date and the endAt date is after the current date.

🧪 How Has This Been Tested?

Manual testing and existing/new unit tests

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

Copy link

Coverage after merging 1161-check-course-eval-dates into master will be

75.20%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.55%100%100%4.55%28, 30–38, 41–48, 51–53
lib/data/models
   broadcast_message.dart100%100%100%100%
   quick_link.dart100%100%100%100%
   quick_link_data.dart100%100%100%100%
   quick_links.dart100%100%100%100%
   emergency_procedures.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
lib/data/models/hello
   report_news.dart100%100%100%100%
   activity_area.dart56.52%100%100%56.52%31, 34–40, 42–43
   news.dart49.09%100%100%49.09%101, 103–114, 83, 86–99
   organizer.dart100%100%100%100%
   paginated_news.dart30.43%100%100%30.43%34–39, 42, 45–51, 53, 55
   report.dart14.29%100%100%14.29%15–17, 20–22
   news_tags.dart5%100%100%5%13–17, 19–23, 26, 29–34, 36–37
lib/data/repositories
   author_repository.dart0%100%100%0%13–14
   broadcast_message_repository.dart0%100%100%0%13–16, 18–24
   course_repository.dart83.96%100%100%83.96%173, 178, 183–185, 189, 192, 195–200, 204, 206, 209–213, 217, 221–222, 224, 227, 279, 286, 288, 433, 78
   news_repository.dart0%100%100%0%16–17
   quick_link_repository.dart77.78%100%100%77.78%33–34
   settings_repository.dart84.88%100%100%84.88%163, 169, 171, 175, 177, 195, 197–198, 210, 212–213, 36, 79
   user_repository.dart96.36%100%100%96.36%175–176
lib/data/services
   analytics_service.dart0%100%100%0%14, 17–19, 22, 27–29, 33–34, 36, 39
   auth_service.dart0%100%100%0%101–102, 108, 110–112, 114–115, 22–24, 26, 28–31, 33, 36–37, 40, 44, 46, 49–50, 56–57, 62–63, 68, 72–73, 77–78, 80–81, 86, 90–91, 94–95, 97–98
   cache_service.dart0%100%100%0%30–31, 34–35, 38, 42, 44–46, 52, 54–56, 61, 63–65
   in_app_review_service.dart0%100%100%0%16, 20, 23, 27
   launch_url_service.dart0%100%100%0%14–17, 19, 23–26, 28, 32–35, 40, 44
   navigation_service.dart0%100%100%0%30, 33–34, 36–37, 44–45, 48–49, 52–53, 55, 60–61, 64–65, 68–69, 72, 75, 77, 82, 84, 86–87, 90–91, 93
   remote_config_service.dart0%100%100%0%100–101, 104–106, 109–111, 114–116, 119–121, 124–126, 129–131, 134–136, 139–141, 144–146, 149–151, 154–156, 159–160, 162–165, 169–171, 59–61, 64–66, 69–71, 74–76, 79–81, 84–86, 89–91, 94–96, 99
   networking_service.dart0%100%100%0%10, 12–14, 17–19
   preferences_service.dart63.64%100%100%63.64%107–108, 110, 26–27, 29, 32–34, 47, 56–59, 69–71, 74–76
   calendar_service.dart0%100%100%0%100, 106, 110, 112–117, 119, 122–124, 130–131, 134, 137, 141, 148, 15, 152, 155, 157, 16, 162, 166–167, 171–176, 18, 180, 184, 20, 22, 24, 26, 40, 42–43, 45–46, 49, 53–56, 64, 66–67, 70, 74, 77, 83, 85–86, 89, 93–94, 98–99
   navigation_history_observer.dart0%100%100%0%11, 14–16, 18, 20, 22, 25, 27, 30, 32
lib/data/services/hello
   hello_service.dart100%100%100%100%
lib/data/services/hello/commands
   get_events_command.dart73.08%100%100%73.08%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart91.67%100%100%91.67%26
   report_news_command.dart92.86%100%100%92.86%27
lib/data/services/signets-api
   signets_api_client.dart100%100%100%100%
   request_builder_service.dart100%100%100%100%
lib/data/services/signets-api/commands
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/data/services/signets-api/models
   course.dart83.56%100%100%83.56%102, 117, 119–128
   course_activity.dart81.40%100%100%81.40%83, 85–91
   schedule_activity.dart80.65%100%100%80.65%116, 118–128
   session.dart67.82%100%100%67.82%136, 138–150, 152, 154–166
   profile_student.dart93.10%100%100%93.10%64–65
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
   course_review.dart51.92%100%100%51.92%100–101, 49–56, 68, 70–77, 93, 95–99
   course_summary.dart85.07%100%100%85.07%100–108, 98
   course_evaluation.dart68.63%100%100%68.63%155, 157–170, 172, 174–188, 49
lib/domain/constants
   preferences_flags.dart0%100%100%0%39, 41, 43, 45, 48, 50–53, 55–56
   markers.dart100%100%100%100%
lib/ui/choose_language/view_model
   choose_language_viewmodel.dart100%100%100%100%
lib/ui/choose_language/widgets
   choose_language_view.dart94.44%100%100%94.44%33–34
lib/ui/core/themes
   app_palette.dart100%100%100%100%
   app_colors_extension.dart1.54%100%100%1.54%100–126, 129, 131, 136, 140–169, 66, 97–99
   app_theme.dart13.46%100%100%13.46%101–102, 104, 109, 11, 111, 113, 119–120, 13, 139, 14, 140, 15, 18–19, 21–23, 25, 27–29, 33–37, 40–41, 43, 48, 50, 83–84, 86–88, 90, 92–93, 95–98
lib/ui/core/ui
   base_navigation_bar.dart97.67%100%100%97.67%100
   base_scaffold.dart67.69%100%100%67.69%100, 103–104, 106, 108–113, 115, 153–154, 156–160, 162–163, 95
   bottom_bar.dart100%100%100%100%
   navigation_rail.dart88.89%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants