Add raid hero gifts for the fluix researcher villager

[Mithi83]

Fixes #8456

[Mithi83]

Draft as I'm not familiar enough with datagen and also the actual loot needs to be determined.

[Technici4n]

If you want an example: AztechMC/Modern-Industrialization#980

[Mithi83]

Thanks for your example, that would have saved me some trial and error I guess. All in all it seems rather similar to my draft, in particular the generated JSON seems to be very similar.

One improvement I'll make is the explict number of rolls on the loot table. Relying on the default value is perhaps not the best idea.

Another difference is the use of record vs class for MIGiftLoot. Since registries is never used, is there any particular reasoning for choosing one over the other? Is it somehow considered cleaner? Bear in mind that Java is not my main programming language.

General question for all reviewers: Any suggestions for the actual loot you'd like to see on this loot table?

[Technici4n]

The record is not really needed here, no. What you have is fine.

Regarding the loot I have no idea. Maybe look at the normal villager trades for inspiration.

[Mithi83]

Good idea:

        buyItems(trades, 1, AEItems.CERTUS_QUARTZ_CRYSTAL, 3, 4, 10);
        buyItems(trades, 1, AEItems.METEORITE_COMPASS, 2, 1, 5);

        buyItems(trades, 2, AEBlocks.SKY_STONE_BLOCK, 5, 8, 20);

        buyItems(trades, 3, AEItems.FLUIX_CRYSTAL, 5, 4, 14);

        buyItems(trades, 4, AEItems.CALCULATION_PROCESSOR_PRESS, 10, 1, 20);
        buyItems(trades, 4, AEItems.ENGINEERING_PROCESSOR_PRESS, 10, 1, 20);
        buyItems(trades, 4, AEItems.LOGIC_PROCESSOR_PRESS, 10, 1, 20);
        buyItems(trades, 4, AEItems.SILICON_PRESS, 10, 1, 20);

        buyItems(trades, 5, Items.SLIME_BALL, 8, 5, 12);

Those are the trades the fluix researcher offers (at least what you can buy there, rather than sell). From those only sky stone block seems interesting, other than the certus quartz crystal and fluix crystal from my first draft. Presses and the meteorite compass are not required in large quantities and therefore not interesting in my opinion.

Slime balls as highest level trades seems like a remnant of old times, as in 1.21 the requirements for slime balls (for sticky pistons for inscribers?) was removed as far as I remember from AE2.

[Technici4n]

Sky stone and crystals sound good. Maybe something a bit "fancy" as well?

[Mithi83]

I've added the explicit number of rolls as well as the sky stone. As for something a bit more fancy, what are you thinking about? I don't want to overdo it and accidentially ruin the balance if this game mechanic can somehow be exploited or trivially automated.

• Silicon (which is trivial to obtain if you can get certus quartz and thus a bit redudant)
• Charged certus quartz (again rather redundant)
• Processors
• Formation or annihilation cores
• Low level storage components (1k or maybe 4k)

[Technici4n]

Good enough for a first version of the loot.