Sonar: Promises should not be misusedjavascript:S6544

[jirihofman]

What

• Sonar reported few problems.
• I put it into VSC Copilot Agent
• The diff should be viewed without whitespace changes. It makes much more sense - https://github.com/clientIO/appmixer-connectors/pull/591/files?diff=split&w=1

How

I extracted a single problem reported by SonarQube and put it into CSV agent. The prompt:

Fix issues reported by SonarQube. The list follows.

src/appmixer/aws/s3/PutObject/PutObject.js
Promise returned in function argument where a void return was expected.

async
promise
+
Not assigned
5min effort
1 year ago
src/appmixer/cloudflare/jobs.lists.js
Promise returned in function argument where a void return was expected.

async
promise
+
Not assigned
1
5min effort
2 months ago
src/appmixer/cloudflareWAF/jobs.waf.js
Promise returned in function argument where a void return was expected.

async
promise
+
Not assigned
5min effort
2 months ago
src/appmixer/hubspot/routes.js
Promise returned in function argument where a void return was expected.

async
promise
+
Jiří Hofman
5min effort
2 months ago
Promise returned in function argument where a void return was expected.

async
promise
+
Jiří Hofman
5min effort
2 months ago
src/.../kafka/platform/SendMessage/SendMessage.js
Promise returned in function argument where a void return was expected.

async
promise
+
David Durman
5min effort
2 months ago
src/appmixer/mongodb/common.js
Promise returned in function argument where a void return was expected.

async
promise
+
Not assigned
5min effort
2 months ago
src/appmixer/rabbitmq/connections.js
Promise returned in function argument where a void return was expected.

async
promise
+
David Durman
5min effort
7 months ago
src/.../rabbitmq/platform/Publish/Publish.js
Promise returned in function argument where a void return was expected.

async
promise
+
David Durman
5min effort
2 months ago
src/.../rabbitmq/platform/SendToQueue/SendToQueue.js
Promise returned in function argument where a void return was expected.

async
promise
+
David Durman
5min effort
2 months ago
src/appmixer/utils/csv/CSVProcessor.js
Promise returned in function argument where a void return was expected.

async
promise
+
Jiří Hofman
5min effort
2 months ago

Manual intervention

• src/appmixer/utils/csv/CSVProcessor.js - halucinated the interval, had to revert it back
• src/appmixer/utils/csv/CSVProcessor.js - I simply removed async
• src/appmixer/rabbitmq/connections.js - TODO: add lost code ⚠️

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.