Skip to content

feat: security feature - login history readme #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: POLARDB_15_STABLE
Choose a base branch
from

Conversation

manfuldrifter
Copy link

Add the readme file

@polardb-bot
Copy link

polardb-bot bot commented Apr 23, 2025

Hi @manfuldrifter ~ Thanks for your contribution in this PR. ❤️

Please make sure that your PR conforms the standard, and has passed all the checks.

We will review your PR as soon as possible.

@polardb-bot
Copy link

polardb-bot bot commented Apr 23, 2025

Hey @manfuldrifter :

Something wrong occuried during the checks of your commit 😟, please check the detail:

⚠️ docs-format-check View more details

@polardb-bot polardb-bot bot added the ci/failure CI status is failure label Apr 23, 2025
Copy link
Member

@mrdrivingduck mrdrivingduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see and apply the diff inside docs-format check :)


# polar_login_history 会话访问历史

<Badge type="tip" text="V11 / v1.1.1-" vertical="top" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number seems incorrect. It should be V15 / v${show polar_version;}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other places that need to be modified besides this? I can't see the detailed error message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed error can be found here, but the version number is not an error can be found by CI: https://github.com/ApsaraDB/PolarDB-for-PostgreSQL/actions/runs/14609254496/job/40984125189?pr=577

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor version number seems not right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean v1.1.1? What should it be written as?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execute show polar_version by psql, it should be like v15.x.x.x

@polardb-bot
Copy link

polardb-bot bot commented Apr 30, 2025

Hey @manfuldrifter :

Something wrong occuried during the checks of your commit 😟, please check the detail:

⚠️ docs-format-check View more details

@polardb-bot polardb-bot bot added ci/failure CI status is failure and removed ci/failure CI status is failure labels Apr 30, 2025
@polardb-bot
Copy link

polardb-bot bot commented Apr 30, 2025

Hey @manfuldrifter :

Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review.

@polardb-bot polardb-bot bot added ci/success CI status is success and removed ci/failure CI status is failure labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/success CI status is success
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants