-
Notifications
You must be signed in to change notification settings - Fork 488
feat: security feature - login history readme #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: POLARDB_15_STABLE
Are you sure you want to change the base?
feat: security feature - login history readme #577
Conversation
Add the readme file
Hi @manfuldrifter ~ Thanks for your contribution in this PR. ❤️ Please make sure that your PR conforms the standard, and has passed all the checks. We will review your PR as soon as possible. |
Hey @manfuldrifter : Something wrong occuried during the checks of your commit 😟, please check the detail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see and apply the diff inside docs-format check :)
|
||
# polar_login_history 会话访问历史 | ||
|
||
<Badge type="tip" text="V11 / v1.1.1-" vertical="top" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number seems incorrect. It should be V15 / v${show polar_version;}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other places that need to be modified besides this? I can't see the detailed error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed error can be found here, but the version number is not an error can be found by CI: https://github.com/ApsaraDB/PolarDB-for-PostgreSQL/actions/runs/14609254496/job/40984125189?pr=577
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minor version number seems not right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean v1.1.1? What should it be written as?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Execute show polar_version
by psql, it should be like v15.x.x.x
Add the readme file
Hey @manfuldrifter : Something wrong occuried during the checks of your commit 😟, please check the detail:
|
Add the readme file
Hey @manfuldrifter : Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review. |
Add the readme file