Particle bioshade and cdom light extinction #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
These two issues are interconnected because they both use diagnostic variables, rather than state variables, in the light extinction function. Diagnostic variables have a value of 0 before the
calculate_fluxesfunction is called. Soupdate_lightneeds to be called aftercalculate_fluxesso that the updated Kw is available to influence the physics. Instead of removing theupdate_lightbeforecalculate_fluxes, I added another call toupdate_light. As a result,update_lightis called twice in a time step. Other than minor additions to the compute, are there any issues with this?Since
aed_light_extinction_phyto_abmis called insideaed_run_columnto determine the particle shading,aed_calculate_particlesneeds to be called beforeaed_run_columnso that the_DIAG_VAR_(data%id_phyc)variable is non-zero.However, this fix is not ideal because the bioshape from cdom will always be missing from
calculate_fluxesat the first time step of a simulation. The proper solution would be to initialize the cdom diagnostic at the beginning of the simulation. This would remove the need to callupdate_lightaftercalculate_fluxes.