-
Notifications
You must be signed in to change notification settings - Fork 4
feat(task-uuid): Update identifier of Task from task_id to uuid #230
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net |
str-anger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By itself, the PR is clean and self-descriptive.
- I'd appreciate if you rebase on cancellation PRs to also take care of their changes.
- I'd appreciate to see a migration script as well.
675db3d to
f8f75b0
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net |
f8f75b0 to
1d01922
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net |
str-anger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from comments inline, I think class task.py/TaskProcessExecutionResult also deserves field renaming. Can you please do this, and propagate this rename to the usage (i.e. method _update_task_info)
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net |
str-anger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approve, class TaskProcessExecutionResult may also benefit from renaming of the field.
|
I found some changes which are missed in the |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net |
Changes
task_idtouuidhumanize_listutility function