Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Conversation

@jatinriverlane
Copy link
Collaborator

Changes

  • Made relevant changes to update task_id to uuid
  • Improved humanize_list utility function

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
aqueductcore/backend
   context.py751185%64, 94, 98, 102, 109, 113, 117, 147–151, 158–159
   main.py24867%21–30, 37
   session.py13469%24–28
aqueductcore/backend/models
   orm.py44198%78
aqueductcore/backend/routers
   files.py124695%179–180, 229, 240, 255, 277
   frontend.py241154%22–33, 37
aqueductcore/backend/routers/graphql
   mutations_schema.py461959%44–48, 56–62, 70–74, 82–86, 93–97, 104–105, 112, 120
   query_schema.py421467%47–49, 56–60, 67–71, 82–84, 89, 100, 107
   router.py11191%15
   types.py1363475%27–45, 50–56, 61–68, 166–192, 257–289, 294–305, 312–316
aqueductcore/backend/routers/graphql/mutations
   experiment_mutations.py231248%25–32, 40–47, 55–61, 69–75, 83–89, 97–102
   task_mutations.py11464%18–27, 33–40
aqueductcore/backend/routers/graphql/resolvers
   experiment_resolver.py221055%35, 49–67, 74–87
   tags_resolver.py241538%23–48
   task_resolver.py231248%28–53, 59–65
aqueductcore/backend/services
   experiment.py2203684%82, 86, 96, 100, 102, 112–125, 155, 190, 197, 243, 246, 266, 271, 303, 351, 357, 386, 392, 409, 434, 441, 449, 479–485, 492–496, 508, 511
   extensions.py1534670%41, 44, 61–62, 68–69, 76, 82, 84–85, 120–178, 194, 236, 240, 264, 270, 278
   extensions_executor.py951386%38–41, 49–50, 69, 84, 87, 129–135, 153–159, 181, 191
   task_executor.py15011225%48–52, 76–104, 109–145, 159–166, 175–205, 218–245, 263–319
   utils.py45491%30–51
   validators.py33294%41, 46
aqueductcore/cli
   commands.py60788%32, 82–85, 94–98, 110–114
   exporter.py49198%71
   importer.py61198%90
   main.py34876%97–107, 122–136
TOTAL178239278% 

Tests Skipped Failures Errors Time
92 0 💤 0 ❌ 0 🔥 11.733s ⏱️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net

@jatinriverlane jatinriverlane changed the title update identifier of Task from task_id to uuid feat(task-uuid): Update identifier of Task from task_id to uuid Oct 8, 2024
@jatinriverlane jatinriverlane marked this pull request as ready for review October 8, 2024 14:43
Copy link
Contributor

@str-anger str-anger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By itself, the PR is clean and self-descriptive.

  1. I'd appreciate if you rebase on cancellation PRs to also take care of their changes.
  2. I'd appreciate to see a migration script as well.

@jatinriverlane jatinriverlane force-pushed the feat/replace-taskid-with-uuid branch from 675db3d to f8f75b0 Compare October 10, 2024 10:19
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net

@jatinriverlane jatinriverlane force-pushed the feat/replace-taskid-with-uuid branch from f8f75b0 to 1d01922 Compare October 11, 2024 10:48
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net

Copy link
Contributor

@str-anger str-anger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from comments inline, I think class task.py/TaskProcessExecutionResult also deserves field renaming. Can you please do this, and propagate this rename to the usage (i.e. method _update_task_info)

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net

Copy link
Contributor

@str-anger str-anger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approve, class TaskProcessExecutionResult may also benefit from renaming of the field.

@safeamiiir
Copy link
Contributor

I found some changes which are missed in the tests/integration/test_graphql_tasks.py file:
like lines: 43, 57, 88, ...
I guess they also need to be modified, right?

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-230.westeurope.3.azurestaticapps.net

@jatinriverlane jatinriverlane merged commit 53db705 into main Oct 14, 2024
26 checks passed
@jatinriverlane jatinriverlane deleted the feat/replace-taskid-with-uuid branch October 14, 2024 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants