-
Notifications
You must be signed in to change notification settings - Fork 4
feat(task-cleanup): Deletion of experiment deletes all tasks related to it #231
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net |
| remove_all_experiment_tasks_statement = delete(orm.Task).where( | ||
| orm.Task.experiment_id == experiment_uuid | ||
| ) | ||
| await db_session.execute(remove_all_experiment_tasks_statement) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm basically seeing these lines as the only actual changes in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Amirreza, we are only removing the Task from task table. This will allow users to debug any failures in code later.
b3090c5 to
f74e1ed
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net |
Changes