Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Conversation

@jatinriverlane
Copy link
Collaborator

@jatinriverlane jatinriverlane commented Oct 9, 2024

Changes

  • On deleting experiment, all tasks related to the task get deleted.
    • Removal of task rows from the Task table.
    • Removal of results, status and everything related to the tasks.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
aqueductcore/backend
   context.py751185%64, 94, 98, 102, 109, 113, 117, 147–151, 158–159
   main.py24867%21–30, 37
   session.py13469%24–28
aqueductcore/backend/models
   orm.py44198%78
aqueductcore/backend/routers
   files.py124695%179–180, 229, 240, 255, 277
   frontend.py241154%22–33, 37
aqueductcore/backend/routers/graphql
   mutations_schema.py461959%44–48, 56–62, 70–74, 82–86, 93–97, 104–105, 112, 120
   query_schema.py421467%47–49, 56–60, 67–71, 82–84, 89, 100, 107
   router.py11191%15
   types.py1363475%27–45, 50–56, 61–68, 166–192, 257–289, 294–305, 312–316
aqueductcore/backend/routers/graphql/mutations
   experiment_mutations.py231248%25–32, 40–47, 55–61, 69–75, 83–89, 97–102
   task_mutations.py11464%18–27, 33–40
aqueductcore/backend/routers/graphql/resolvers
   experiment_resolver.py221055%35, 49–67, 74–87
   tags_resolver.py241538%23–48
   task_resolver.py231248%28–53, 59–65
aqueductcore/backend/services
   experiment.py2223684%82, 86, 96, 100, 102, 112–125, 155, 190, 197, 243, 246, 266, 271, 303, 351, 357, 386, 392, 409, 434, 441, 449, 479–485, 492–496, 508, 511
   extensions.py1534670%41, 44, 61–62, 68–69, 76, 82, 84–85, 120–178, 194, 236, 240, 264, 270, 278
   extensions_executor.py951386%38–41, 49–50, 69, 84, 87, 129–135, 153–159, 181, 191
   task_executor.py15011225%48–52, 76–104, 109–145, 159–166, 175–205, 218–245, 263–319
   utils.py45491%30–51
   validators.py33294%41, 46
aqueductcore/cli
   commands.py60788%32, 82–85, 94–98, 110–114
   exporter.py49198%71
   importer.py61198%90
   main.py34876%97–107, 122–136
TOTAL178439278% 

Tests Skipped Failures Errors Time
92 0 💤 0 ❌ 0 🔥 11.174s ⏱️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net

@jatinriverlane jatinriverlane marked this pull request as ready for review October 9, 2024 10:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net

@jatinriverlane jatinriverlane changed the title feat(task-cleanup): Deletion of experiment deleted all tasks related to it feat(task-cleanup): Deletion of experiment deletes all tasks related to it Oct 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net

Comment on lines +525 to +528
remove_all_experiment_tasks_statement = delete(orm.Task).where(
orm.Task.experiment_id == experiment_uuid
)
await db_session.execute(remove_all_experiment_tasks_statement)
Copy link
Contributor

@safeamiiir safeamiiir Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm basically seeing these lines as the only actual changes in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Amirreza, we are only removing the Task from task table. This will allow users to debug any failures in code later.

@jatinriverlane jatinriverlane force-pushed the feat/TT-129-Job-History-Cleanup branch from b3090c5 to f74e1ed Compare October 14, 2024 09:44
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sand-0b0e2a903-231.westeurope.3.azurestaticapps.net

@jatinriverlane jatinriverlane merged commit f2ad769 into main Oct 14, 2024
26 checks passed
@jatinriverlane jatinriverlane deleted the feat/TT-129-Job-History-Cleanup branch October 14, 2024 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants