camera: action API support #468
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelP
force-pushed
the
wip/action
branch
from
3b331cf to
7df8471
Compare
Without implementation for now.
EmmanuelP
commented
Aug 10, 2021
Contributor
Author
EmmanuelP
left a comment
EmmanuelP
left a comment
There was a problem hiding this comment.
I'm not fond of the current API. It is too low level.
May be a better approach would be to configure the action with just giving a set of devices. We may be able to automatically define the needed keys, and have a *_full version with user given key values. I guess the broadcast address can be also found automatically, or set explicetely in the *_full API version.
Comment on lines
+2764
to
+2771
| if (error == NULL) | ||
| arv_camera_set_string (camera, "ActionSelector", command_name, &local_error); | ||
| if (error == NULL) | ||
| arv_camera_set_integer (camera, "ActionDeviceKey", device_key, &local_error); | ||
| if (error == NULL) | ||
| arv_camera_set_integer (camera, "ActionGroupKey", group_key, &local_error); | ||
| if (error == NULL) | ||
| arv_camera_set_integer (camera, "ActionGroupMask", group_key, &local_error); |
Contributor
Author
There was a problem hiding this comment.
Should test local_error, not error
Comment on lines
+431
to
+438
| arv_gv_device_issue_scheduled_action_command (guint32 device_key, guint32 group_key, guint32 group_mask, | ||
| guint64 timestamp_ns, GInetAddress *broadcast_address, | ||
| GInetAddress **inet_addresses, guint *n_acknowledges, | ||
| GError **error) | ||
| { | ||
| return FALSE; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
TODO: actual implementation
Comment on lines
+83
to
+87
| gboolean arv_gv_device_issue_scheduled_action_command (guint32 device_key, guint32 group_key, guint32 group_mask, | ||
| guint64 timestamp_ns, GInetAddress *broadcast_address, | ||
| GInetAddress **inet_addresses, guint *n_acknowledges, | ||
| GError **error); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
TODO: actual implementation
Comment on lines
+2801
to
+2802
| * @inet_addresses: (out): a placeholder for an array of acknowledge IP adresses | ||
| * @n_acknowledges: (out): a placeholder for the number of ackowledges |
Contributor
Author
There was a problem hiding this comment.
API: we should handle devices by using #ArvDevice instances here, not by their IP addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.