Skip to content

Keep reading if TriggerMode is set to On #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lc-spxl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Keep reading if TriggerMode is set to On #705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c7871
when TriggerMode = On do not exit if buffer is empty on gst pipeline …
lc-spxl Aug 12, 2022
e729f2a
remove repeating log message
lc-spxl Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions gst/gstaravis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,15 +570,48 @@ gst_aravis_create (GstPushSrc * push_src, GstBuffer ** buffer)
gst_aravis = GST_ARAVIS (push_src);
base_src_does_timestamp = gst_base_src_get_do_timestamp(GST_BASE_SRC(push_src));

// get trigger mode
GError *error = NULL;

gboolean triggerModeEnabled = FALSE;
gboolean triggerModeAvail = arv_device_is_feature_available (arv_camera_get_device (gst_aravis->camera), "TriggerMode", &error);

if (error != NULL) {
GST_ERROR_OBJECT (gst_aravis, "Check TriggerMode avail failed: %d %s", error->code, error->message);
return GST_FLOW_ERROR;
}

if (triggerModeAvail) {

ArvGcNode *feature = arv_device_get_feature (arv_camera_get_device (gst_aravis->camera), "TriggerMode");
const char *value = arv_gc_string_get_value (ARV_GC_STRING (feature), &error);

if (error != NULL) {
GST_ERROR_OBJECT (gst_aravis, "Read TriggerMode failed: %d %s", error->code, error->message);
return GST_FLOW_ERROR;
}

triggerModeEnabled = strcmp(value, "On") == 0;
}

GST_OBJECT_LOCK (gst_aravis);

do {
if (arv_buffer) arv_stream_push_buffer (gst_aravis->stream, arv_buffer);
arv_buffer = arv_stream_timeout_pop_buffer (gst_aravis->stream, gst_aravis->buffer_timeout_us);
} while (arv_buffer != NULL && arv_buffer_get_status (arv_buffer) != ARV_BUFFER_STATUS_SUCCESS);

if (arv_buffer == NULL)
if (arv_buffer == NULL && triggerModeEnabled) {
GST_DEBUG_OBJECT (gst_aravis, "Waiting for buffer");
}

} while (
(arv_buffer == NULL && triggerModeEnabled) ||
(arv_buffer != NULL && arv_buffer_get_status (arv_buffer) != ARV_BUFFER_STATUS_SUCCESS)
);

if (arv_buffer == NULL) {
goto error;
}

buffer_data = (char *) arv_buffer_get_data (arv_buffer, &buffer_size);
arv_buffer_get_image_region (arv_buffer, NULL, NULL, &width, &height);
Expand Down
Loading