feat(vaults): add Joi validation for vault configuration (#3) - #5
Open
Cid-oe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3.
Implements dedicated Joi validation for Vault configuration in the Arbellar Backend matching the Phase 1 Core MVP specification.
Changes
src/modules/vaults/vault.validation.ts:vaultConfigSchemacovering required fields (name,riskLevel,minSpread,maxSlippage,autoReinvest) and optional fields (description,tradeSizeLimit) withstripUnknown: true.validateVaultConfig(config)returning cleaned data and throwingValidationErroron failure.isValidVaultConfig(config)returning a boolean.src/modules/vaults/vault.test.tsverifying happy path, unknown field stripping, missing required fields, invalid risk levels, negative bounds, and boolean type checking.vitest.config.tsto include test files insrc/.src/modules/vaults/README.mdto document the new validation helper functions and schema.Validation
pnpm testpasses (11 tests pass across suite).pnpm typecheckpasses cleanly.pnpm format:checkpasses.