feat(middleware): sanitize sensitive fields from error responses (#4) - #6
Open
Cid-oe wants to merge 1 commit into
Open
feat(middleware): sanitize sensitive fields from error responses (#4)#6Cid-oe wants to merge 1 commit into
Cid-oe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4.
Adds a pure, structured error-response sanitizer helper module in
src/middleware/errorResponse.tsand integrates it intoerrorHandlerto prevent sensitive fields (credentials, private keys, database connection strings, tokens, etc.) from leaking in error responses.Changes
src/middleware/errorResponse.tsexporting:DENY_LISTED_KEYS: Set of sensitive keys to strip (case-insensitively).sanitizeErrorDetails: Pure recursive function removing sensitive keys from objects and arrays, while passing primitives and nullish values safely through.src/middleware/index.ts.src/middleware/errorHandler.tsto passdetailsand object developmenterror.stackthroughsanitizeErrorDetails.tests/unit/middleware/errorResponse.test.tscovering:Verification
pnpm test: 9/9 tests passpnpm typecheck: zero type errorspnpm format:check: all files format compliantpnpm lint: 0 errors