feat(middleware): sanitize sensitive fields from error responses - #7
Open
slsgzs-cloud wants to merge 4 commits into
Open
feat(middleware): sanitize sensitive fields from error responses#7slsgzs-cloud wants to merge 4 commits into
slsgzs-cloud wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4.
Adds a structured error-response sanitizer that strips sensitive fields from JSON error responses before they leave the Arbellar Backend.
Changes
New:
src/middleware/errorResponse.tsPure, unit-testable helper:
Deny-list (case-insensitive, recursive, arrays handled):
password, passwordHash, secret, token, apiKey, privateKey, private_key, keypair, seed, mnemonic, jwt, authorization, mongodbUri, connectionString, uri, cursor, stackTrace, stack, internal, env, process
Updated:
src/middleware/errorHandler.tsPasses
detailsthroughsanitizeErrorDetails()before attaching to the response. Existingsuccess: false+error.code/error.message/error.detailsshape is preserved. Devstackexposure unchanged.Updated:
src/middleware/index.tsExports the new
errorResponsemodule.New:
tests/unit/middleware/errorResponse.test.ts10 test cases covering:
Acceptance Criteria
sanitizeErrorDetailsadded as pure helpererrorHandlerapplies the helper todetailsVerification
pnpm test pnpm lint pnpm typecheck pnpm format:checkCI will validate on merge.