#2043 add BasicHaTest and first simple resync scenario #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
lvca
reviewed
Mar 14, 2025
| checkDatabaseIsOpen(); | ||
| stats.commands.incrementAndGet(); | ||
|
|
||
| return (ResultSet) databaseCommand("command", language, command, params, true, |
There was a problem hiding this comment.
Why are you setting false = not require a leader? This means the operation will go to any server, but if it's an update (query is idempotent) will bounce to the leader in 2 passes
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
c12ede7 to
697f2fc
Compare
lvca
approved these changes
Mar 20, 2025
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
697f2fc to
2832b8f
Compare
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
2832b8f to
db7bd83
Compare
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
db7bd83 to
5f527f2
Compare
robfrank
force-pushed
the
feature/2043-ha-test
branch
5 times, most recently
from
af3014c to
73b2324
Compare
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
e287b3b to
7dad934
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
robfrank
force-pushed
the
feature/2043-ha-test
branch
3 times, most recently
from
369a5b8 to
9777a56
Compare
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
9777a56 to
f82c3af
Compare
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
f82c3af to
aea3728
Compare
…ontainersTestTemplate
…roving edge creation logic
robfrank
force-pushed
the
feature/2043-ha-test
branch
from
9cbd9f6 to
19a7849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds test that uses Toxiporxy to simulate network problems
Motivation
redesign HA tests using containers
Related issues
#2043
Checklist
mvn clean packagecommand