Skip to content

fix: improve root user password check logic in ServerSecurity #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: improve root user password check logic in ServerSecurity #2149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f40752
fix: improve root user password check logic in ServerSecurity
Apr 11, 2025
95047eb
fixes #2150
Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions server/src/main/java/com/arcadedb/server/security/ServerSecurity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import com.arcadedb.database.DatabaseInternal;
import com.arcadedb.log.LogManager;
import com.arcadedb.security.SecurityManager;
import com.arcadedb.serializer.json.JSONArray;
import com.arcadedb.serializer.json.JSONException;
import com.arcadedb.serializer.json.JSONObject;
import com.arcadedb.server.ArcadeDBServer;
Expand Down Expand Up @@ -125,7 +126,7 @@ public void loadUsers() {
}
}

if (users.isEmpty() || (users.containsKey("root") && users.get("root").getPassword() == null))
if (users.isEmpty() || !users.containsKey("root") || (users.containsKey("root") && users.get("root").getPassword() == null))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean we could even remove users.isEmpty()

askForRootPassword();

final long fileLastModified = usersRepository.getFileLastModified();
Expand Down Expand Up @@ -447,7 +448,9 @@ protected void askForRootPassword() throws IOException {
getUser("root").setPassword(encodedPassword);
saveUsers();
} else
createUser(new JSONObject().put("name", "root").put("password", encodedPassword));
createUser(new JSONObject().put("name", "root")
.put("password", encodedPassword)
.put("databases", new JSONObject().put(SecurityManager.ANY, new JSONArray(new String[] { "admin" }))));
}

protected JSONObject getDatabaseGroupsConfiguration(final String databaseName) {
Expand Down
Loading