test: add regression tests for SQL Index ORDER BY duplicates issue (#1760)

[robfrank]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive suite of regression tests to ensure the stability and correctness of SQL queries involving ORDER BY clauses on indexed properties. These tests specifically target and validate the fix for issue #1760, which addressed a problem where queries on non-unique indexed properties with duplicate values would incorrectly return an inflated number of results. The new tests cover a wide array of scenarios, confirming that the automatic deduplication mechanism functions as expected across different data types, query types, and ordering specifications.

Highlights

• New Regression Test Suite: A new test file, Issue1760ReproductionTest.java, has been added to provide comprehensive regression tests for issue SQL: Index can return too many entries when used with ORDER BY #1760.
• SQL Index ORDER BY Duplicates Fix Validation: The tests specifically target and validate the fix for issue SQL: Index can return too many entries when used with ORDER BY #1760, which addressed a bug where SQL queries with ORDER BY on non-unique indexed properties with duplicate values would return an incorrect number of entries.
• Diverse Test Scenarios: The test suite includes various scenarios such as exact reproduction of the original bug, handling of LONG properties to prevent ClassCastException, UPSERT operations, and ORDER BY clauses with ascending, descending, range queries, and string indexes, all involving duplicate data.
• Automatic Deduplication Verification: The tests confirm that the implemented automatic deduplication mechanism (via IndexSearchDescriptor.requiresDistinctStep() and SelectExecutionPlanner adding DistinctExecutionStep) correctly ensures accurate result counts and ordering.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a comprehensive suite of regression tests for issue #1760, which deals with duplicate entries in ORDER BY queries using indexes. The tests cover a wide range of scenarios and are well-structured. I've provided a few suggestions to improve the robustness and readability of some test assertions. Overall, this is a great addition to ensure the bug remains fixed.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.24%	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (9c8ae17)	72462	45661	63.01%
Head commit (24ac9d0)	72462 (+0)	45834 (+173)	63.25% (+0.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#2561)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences