Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 11, 2025

What does this PR do?

Replaces direct console output with proper logging infrastructure in LSMVectorIndex.loadVectorsFromPages().

Motivation

Addresses code review feedback from #2911. Direct use of System.out.println in library code bypasses log level controls and output routing. The codebase uses LogManager consistently elsewhere.

Related issues

Additional Notes

Changed from string concatenation to format specifiers for cleaner logging:

// Before
System.out.println("loadVectorsFromPages DONE: Loaded " + vectorIndex.size() + " vector locations (" + entriesRead
    + " total entries) for index: " + indexName + ", nextId=" + nextId.get() + "...");

// After  
LogManager.instance().log(this, Level.INFO, "loadVectorsFromPages DONE: Loaded %d vector locations (%d total entries) for index: %s, nextId=%d, fileId=%d, totalPages=%d%s",
    vectorIndex.size(), entriesRead, indexName, nextId.get(), getFileId(), getTotalPages(), ...);

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

lvca and others added 2 commits December 11, 2025 10:41
each entry is not 17 bytes anymore, but variable. Also got rid of page header, because LSM are immutable only. Pointers are now absolute pointers.
Base automatically changed from lsm-vector-ultra-compressed to main December 11, 2025 15:49
Copy link
Contributor Author

Copilot AI commented Dec 11, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • repository.apache.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1 -Dlibrary.jansi.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/arcadedb/arcadedb org.codehaus.plexus.classworlds.launcher.Launcher -f pom.xml -B -V -e -Dfindbugs.skip -Dcheckstyle.skip -Dpmd.skip=true -Dspotbugs.skip -Denforcer.skip -Dmaven.javadoc.skip -DskipTests (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on improved compression with lsm vectors Replace System.out.println with LogManager in LSMVectorIndex Dec 11, 2025
Copilot AI requested a review from lvca December 11, 2025 16:00
@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2025

🧪 CI Insights

Here's what we observed from your CI run for d335d25.

🟢 All jobs passed!

But CI Insights is watching 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants