new class implemented: surface fitting - #24
Open
imapeartree wants to merge 5 commits into
Open
Conversation
Member
|
I think most/all the functionality of SurfaceFitter are already in ModalDecomposer. I'll add the documentation to ModalDecomposer and we'll check if it overlaps SurfaceFitter and where to extend it |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 70.88% 71.07% +0.18%
==========================================
Files 135 137 +2
Lines 8819 8977 +158
==========================================
+ Hits 6251 6380 +129
- Misses 2568 2597 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
surface fitting: get a masked array, get coefficients of Zernike or polynomial expansions