Skip to content

new class implemented: surface fitting - #24

Open
imapeartree wants to merge 5 commits into
masterfrom
zenike_improvement
Open

new class implemented: surface fitting#24
imapeartree wants to merge 5 commits into
masterfrom
zenike_improvement

Conversation

@imapeartree

Copy link
Copy Markdown
Collaborator

surface fitting: get a masked array, get coefficients of Zernike or polynomial expansions

@lbusoni

lbusoni commented Jul 9, 2021

Copy link
Copy Markdown
Member

I think most/all the functionality of SurfaceFitter are already in ModalDecomposer. I'll add the documentation to ModalDecomposer and we'll check if it overlaps SurfaceFitter and where to extend it

@codecov-commenter

codecov-commenter commented Jul 13, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.76101% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.07%. Comparing base (e6e71d9) to head (dba3f11).
⚠️ Report is 395 commits behind head on master.

Files with missing lines Patch % Lines
arte/utils/surface_fitter.py 73.78% 27 Missing ⚠️
arte/utils/shape_fitter.py 66.66% 1 Missing ⚠️
test/utils/surface_fitter_test.py 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   70.88%   71.07%   +0.18%     
==========================================
  Files         135      137       +2     
  Lines        8819     8977     +158     
==========================================
+ Hits         6251     6380     +129     
- Misses       2568     2597      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants