Fix tests for refactored Search and SearchResponse classes#25
Draft
Copilot wants to merge 3 commits intorefactor-searchfrom
Draft
Fix tests for refactored Search and SearchResponse classes#25Copilot wants to merge 3 commits intorefactor-searchfrom
Copilot wants to merge 3 commits intorefactor-searchfrom
Conversation
Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>
Co-authored-by: mekarpeles <978325+mekarpeles@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor DataProvider and implement Search class
Fix tests for refactored Search and SearchResponse classes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DataProvider refactoring introduced top-level
SearchandSearchResponseclasses, breaking tests that referenced the old nestedDataProvider.SearchResponse.Test updates:
SearchandSearchResponseas top-level classesSearchResponsewith newSearchobject instead of individual parameters:SearchResponse enhancements:
limit,titleproperties andget_search_url(page)method for pagination__getitem__to raiseKeyErrorfor Mapping interface compliancesplit('{')[0]to[:index('{')]Models updates:
Searchdataclass frommodels.py'DataProvider.SearchResponse'to'SearchResponse'itemsPerPageandcurrentPagefields toMetadatafor paginationSearchandSearchResponsein public APIAll 27 tests now pass with no security issues.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.