Use importlib to handle version and package resources, where available#1462
Merged
Conversation
Contributor
Author
|
Rejig this to just use importlib on Windows |
peterbarker
force-pushed
the
pr/importlib
branch
from
7a48110 to
dad8a1f
Compare
Contributor
Author
|
Since pkg_resources is going away and importlib has worked since forever, move to just using it now. |
peterbarker
force-pushed
the
pr/importlib
branch
2 times, most recently
from
605ce0f to
a6eddc4
Compare
Contributor
Author
|
Closes #1672 |
peterbarker
force-pushed
the
pr/importlib
branch
from
a6eddc4 to
587e855
Compare
removes warnings under 3.12
stephendade
force-pushed
the
pr/importlib
branch
from
587e855 to
f01d957
Compare
Contributor
|
Tested on Windows. Works well! |
Contributor
Author
Fantastic, thanks! Merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fall back to the previous efforts on failure.
Tested back to 3.6
2.7 was a complete write-off due to pre-existing changes.