geodesic_grid: fix undefined variable in _triangle_index neighbor-umbrella path#1669
Open
aryanputta wants to merge 1 commit into
Open
geodesic_grid: fix undefined variable in _triangle_index neighbor-umbrella path#1669aryanputta wants to merge 1 commit into
aryanputta wants to merge 1 commit into
Conversation
peterbarker
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_triangle_indexingeodesic_grid.pycalls_from_neighbor_umbrellawith four arguments:inclusiveis never defined anywhere in_triangle_index. Running this path raises aNameErrorat runtime. Additionally,_from_neighbor_umbrella(line 204) only accepts three parameters(idx, v, u), so even ifinclusivewere defined the call would raise aTypeError.Flake8 also flags this as F821 (undefined name).
Closes #1607
Fix
Remove the spurious
inclusiveargument so the call matches the function signature:Testing
Ran the existing geodesic grid unit tests locally -- all pass. The neighbor-umbrella path in
_triangle_indexnow executes without error.Checklist