Drop python 3.9#1649
Open
amilcarlucas wants to merge 6 commits into
Open
Conversation
amilcarlucas
force-pushed
the
drop_python_3.9
branch
from
79192b7 to
b0fc42e
Compare
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
Test Results 4 files 4 suites 42m 14s ⏱️ For more details on these failures, see this check. Results for commit 4b979e2. ♻️ This comment has been updated with latest results. |
amilcarlucas
force-pushed
the
drop_python_3.9
branch
2 times, most recently
from
c2a7c13 to
bc1ad8c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 107 out of 107 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
scripts/generate_pdef.xml_metadata.py:53
importlib.util.find_spec()expects a module name (e.g.,lxml), butpackageincludes a version specifier (lxml==6.1.1), so this check will always fail and will always attempt to reinstall the dependency.
| rm -Rf build dist/ ardupilot_methodic_configurator.egg-info/ | ||
|
|
||
| uv venv --python 3.12 | ||
| uv venv --python 3.12 .venv-3.12 |
amilcarlucas
force-pushed
the
drop_python_3.9
branch
2 times, most recently
from
aa9b4d6 to
42be790
Compare
Bumps [mypy](https://github.com/python/mypy) from 1.18.2 to 1.19.1. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.18.2...v1.19.1) --- updated-dependencies: - dependency-name: mypy dependency-version: 1.19.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
BREAKING CHANGE: Python 3.9 is EOL and no longer supported. - Update requires-python to >=3.10 in pyproject.toml - Remove Python 3.9 classifier and 3.9-only matplotlib dependency - Set ruff target-version to py310 - Update CI matrix minimum version from 3.9 to 3.10 (pytest, pylint, pyright workflows) - Modernize 512 typing annotations: Optional[X]?X|None, Union[X,Y]?X|Y - Remove redundant Optional/Union imports from typing module - Update test asserting UnionType origin to use types.UnionType instead of typing.Unionfix tests
…et_selected_key
Tcl 9.0 (bundled with uv standalone Python 3.10) changed the behavior of
ttk.Combobox.current(): when no item is selected it now returns "" (empty
string) instead of -1. The old guard `if i_index < 0` cannot handle this
because `self.tk.getint("")` raises TclError before the comparison is
reached, silently killing Tkinter event callbacks.
The broken callbacks left the ESC->FC protocol combobox entries in a stale
state (showing all options instead of the protocol-filtered subset), causing
four GUI integration tests to fail only on the Python 3.10 CI job:
- test_cascade_2_fc_esc_protocol_change_to_dshot150_expands_telem_type_widget_entries
- test_cascade_2_fc_esc_protocol_change_to_brushed_restricts_telem_type_widget_to_none
- test_cascade_3_telem_type_change_from_none_to_main_out_shows_bdshot_protocol_in_widget
- test_cascade_3_telem_type_change_from_none_to_serial_updates_protocol_widget
Fix get_selected_key() to catch TypeError (raised by the comparison on "")
and also guard explicitly against None/"" before the `< 0` check, so the
method safely returns None under both Tcl 8.6 and Tcl 9.0.
Signed-off-by: Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
amilcarlucas
force-pushed
the
drop_python_3.9
branch
from
42be790 to
4b979e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop python 3.9 as it is EOL
Checklist
git commit --signoff)Testing
Describe how you tested these changes: